Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset 2bc374182ed4 by Andrew Svetlov in branch 'default':
issue #3035: update PendingDeprecationWarning to DeprectionWarning, point
deprecation in tkinter doc
http://hg.python.org/cpython/rev/2bc374182ed4
--
Andrew Svetlov andrew.svet...@gmail.com added the comment:
I've updated the patch following David's recommendations, pushed it into
default branch.
#14446 has been made to remove deprecated code in 3.4
Closing the issue as fixed.
--
resolution: remind - fixed
status: open - closed
Andrew Svetlov andrew.svet...@gmail.com added the comment:
Updated patch. Warning type is DeprecationWarning, docs mentioned that.
--
Added file: http://bugs.python.org/file25067/issue3035.diff
___
Python tracker rep...@bugs.python.org
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3035
___
___
R. David Murray rdmur...@bitdance.com added the comment:
Raymond is suggesting removal in 3.4, and given that we are doing it I don't
see any reason to wait for 3.5, either, so you probably want to update the
warning messages to say 3.4 instead of 3.5. Otherwise it looks good to me.
Ezio
Andrew Svetlov andrew.svet...@gmail.com added the comment:
Thank you, David.
I've updated the patch.
I think making new test for check is easy but Issue14446 is good enough.
Running stupid test doesn't make sense for this case.
--
Added file:
Raymond Hettinger raymond.hettin...@gmail.com added the comment:
Usually, I would counsel against removing anything that isn't broken by design,
but the code for these functions offers nothing substantive. So, +1 for
marking as deprecated in 3.3 and removing in 3.4.
--
nosy:
Andrew Svetlov andrew.svet...@gmail.com added the comment:
David Murray,
I used to think what deprecation process in Python have to go trough
PendingDeprectaionWarning to DeprecationWarning and removing in next next
release at end. Is it right?
Also I thought what that trivial patch does not
R. David Murray rdmur...@bitdance.com added the comment:
You are theoretically right about not posting trivial patches, but as you can
see, sometimes even a trivial patch elicits unexpected insights. So I like to
always post my patches, even the seemingly trivial ones. Then if I don't get
Changes by Andrew Svetlov andrew.svet...@gmail.com:
--
nosy: +asvetlov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue3035
___
___
Python-bugs-list
Andrew Svetlov andrew.svet...@gmail.com added the comment:
Pushed as PendingDepricationWarnings for upcoming 3.3
--
assignee: - asvetlov
resolution: - remind
stage: patch review -
versions: +Python 3.3, Python 3.4 -Python 3.2
___
Python tracker
Roundup Robot devn...@psf.upfronthosting.co.za added the comment:
New changeset d42f264f291e by Andrew Svetlov in branch 'default':
Issue #3035: Unused functions from tkinter are marked as pending peprecated.
http://hg.python.org/cpython/rev/d42f264f291e
--
nosy: +python-dev
R. David Murray rdmur...@bitdance.com added the comment:
PendingDeprecationWarning would mean that we are going to remove it someday.
If you actually want to remove them in a reasonable time, you should use
DeprecationWarning in 3.3, and then remove them in 3.4.
But is there a need to remove
R. David Murray rdmur...@bitdance.com added the comment:
Also, posting a patch for review before committing is a good idea. If you
don't get a review in a reasonable time period, then as a committer you can of
course go ahead and commit, based on your judgement.
--
Terry J. Reedy tjre...@udel.edu added the comment:
I do not know or directly use tkinter enough to judge the proposed removal.
(Although they do look like they might be useless.) I would like to see a
little more explanation on the record. Who wrote
# XXX I don't like these -- take them away?
Brian Curtin cur...@acm.org added the comment:
If this stuff needs to be removed it should probably go through the deprecation
process.
--
keywords: +needs review
nosy: +brian.curtin
priority: - low
stage: - patch review
type: - behavior
versions: +Python 3.2 -Python 3.0
New submission from Guilherme Polo [EMAIL PROTECTED]:
Patch for removing some unwanted, and probably not used, functions at
tkinter/__init__.
--
components: Tkinter
files: removed_index_funcs.diff
keywords: patch, patch
messages: 67669
nosy: gpolo
severity: normal
status: open
title:
17 matches
Mail list logo