[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: The initial issue ("[2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7") is now fixed, so I close the issue. Thanks for the help everyone who helped me on this one! -- resolution: -> fixed stage: -> resolved status: open -> closed

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: Oh cool, with my commit 2ada64d2a073f85f135461833952dbe8d656810d "[2.7] bpo-30694: Upgrade Modules/expat/ to libexpat 2.2.1 (#2300)", and obvious Jeremy's previous fix!, the compile step of "AMD64 Windows7 SP1 VS9.0 2.7" succeeded for the first time since a

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: > Added PR to issue29591 to address issue building Expat. In short, the > project files were not updated along with the copy of Expat. I would prefer to first fix the new vulnerabilities, but upgrading expat to 2.2.1, and then review your change. =>

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: Added PR to issue29591 to address issue building Expat. In short, the project files were not updated along with the copy of Expat. I cannot reproduce the GUI build problem. I would need to see the build logs to attempt to resolve. --

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: So, I made final tests with the merged commit. I manually uninstalled (Active)Perl. Without the commit, the compilation of ssl failed on my Windows VM since I'm using VS 2008. (1) using build.bat git clean -fdx In the VS2008 shell, type: PC\VS9.0\build.bat

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: In a previous build, build 111 (June 6), the compilation of _elementtree succeeded: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20VS9.0%202.7/builds/111/steps/compile/logs/stdio _elementtree - 0 error(s), 10 warning(s) I also see that the

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: I checked AMD64 Windows7 SP1 VS9.0 2.7. Before the commit, the build 129 failed badly when building ssl: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20VS9.0%202.7/builds/129/steps/compile/logs/stdio IOError: [Errno 2] No such file or

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: New changeset ebbccea997e03f60fec8308f2fb9e89a11521a74 by Victor Stinner (Jeremy Kloth) in branch '2.7': bpo-30368: Update build_ssl.py to restore Perl-less building (#1805) https://github.com/python/cpython/commit/ebbccea997e03f60fec8308f2fb9e89a11521a74

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: This is ready to be merged, pending any comments from Zach. -- ___ Python tracker ___

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: Any progress on this issue? The following buildbot still fails to build Python 2.7: http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20VS9.0%202.7 -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: Just a status check, as I would like to see my buildbot go green again. (This along with the PR on issue30339). -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: Updated PR. It seems that in my testing back and forth, some build artifacts were affecting my outcomes. That's what I get for cutting corners... Per Zach's comment, I've changed to VS project files to use the prepare_ssl.py include directories

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Zachary Ware added the comment: Ok, sounds good. The two points you raised on the PR also sound fine, as far as I can tell. -- ___ Python tracker ___

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: OK, testing with the 7.1 SDK installed changes the crashes around, but something is really amiss. I'd like to do more testing, but it will need to wait until morning here. -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: On my VM, ssltests pass, but both the Perl and non-Perl segfault in test_ssl (and many others). My VM has just VS2008 installed, does VS2010 come with an updated SDK? -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Zachary Ware added the comment: I tried out PR1805 with Perl unavailable, and it seemed to build fine with `PC\VS9.0\build.bat -e -d -p x64`. However, trying `PC\VS9.0\amd64\python_d.exe -m test.ssltests` segfaults. Can you reproduce? -- ___

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Jeremy Kloth added the comment: Submitted PR-1805 that should restore perl-less building. Also some open issues as noted in the PR. -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Changes by Jeremy Kloth : -- pull_requests: +1888 ___ Python tracker ___

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Zachary Ware added the comment: The simple fix from my point of view is for Jeremy to install Perl :). But since he also mentioned having a patch ready in bpo-30350, I'd like to see it before declaring that installing Perl is what should be done. -- assignee: christian.heimes ->

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

STINNER Victor added the comment: I don't really care if Jeremy installs Perl on the buildbot or if someone succeed to fix the dependency on the svn repository. I only care of seeing a green buildbot ;-) -- ___ Python tracker

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Zachary Ware added the comment: Perl is not required when using the PCbuild/ build files on any branch. It is currently required to use the PC/VS9.0 build files, at least for 64-bit builds, because I was not able to make it work (and not break the new system) in the time I had to get it

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

Steve Dower added the comment: Perl should not be required - we should be checking these files in to our clone on svn.p.o for use when building. (Perl is only required by whoever creates the source tree, normally Zach.) Perhaps it got missed in the latest update? --

[issue30368] [2.7] OpenSSL compilation fails on AMD64 Windows7 SP1 VS9.0 2.7

New submission from STINNER Victor: See http://bugs.python.org/issue30350#msg293663 http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%20VS9.0%202.7/builds/83/steps/compile/logs/stdio Build started: Project: _ssl, Configuration: Debug|x64 ... No Perl installation was found.