[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Cheryl Sabella added the comment: The original pull request has been closed for inactivity, so this is now available for anyone to work on. Please credit the original author if anyone change is based on the original PR. Thanks! -- nosy: +cheryl.sabella versions: +Python 3.10

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Xiang Zhang added the comment: Hi, Jiri. Could you update your PR and let's continue with this issue? -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Jiri Hnidek added the comment: Hi, good point about *foo.com. It seems this is not valid DNS RR according following RFC: https://tools.ietf.org/html/rfc4592 Especially this section is more focused on allowed combinations of asterisks and other characters:

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Xiang Zhang added the comment: One question about this function: hosts like "*.foo.com" gets an unambiguous intention, but how about hosts like "*foo.com"? Should it match hosts like barfoo.com, or treat it as a typo and not match? Although the link says "asterisks can be used as wildcards"

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Jiri Hnidek added the comment: Hi Xiang, * I added entry to Misc/NEWS * I added my name to Misc/ACKS (without diacritics) * I added/updated several unit tests * I updated PR (two commits squashed into one commit) Cheers, Jiri -- ___ Python tracker

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Xiang Zhang added the comment: Hi Jiri, thanks for your PR. But at least we need a corresponding test and an entry in Misc/NEWS to complete the patch. Also, if your name is not in Misc/ACKS, please add it. :-) -- nosy: +xiang.zhang ___ Python

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

Changes by Roundup Robot : -- pull_requests: +1894 ___ Python tracker ___

[issue30462] urllib does not support NO_PROXY environment variable containing domain with asterisk

New submission from Jiri Hnidek: Module urllib contains method proxy_bypass_environment(domain_name). This method check if domain_name should be excluded from proxying. The domain_name is checked against environment variable no_proxy or NO_PROXY. This variable contains comma separated list of