[issue30487] DOC: automatically create a venv and install Sphinx when running make

Change by Ned Deily : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: @cheryl.sabella I am ok with closing this, but the original motivation for this work was from @zack.ware so he should weigh in. I am not going to work on this any further for the forseeable future (I've got my hands full already with the asyncio docs I'm

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Cheryl Sabella added the comment: I believe this can be closed as resolved? Thanks. -- nosy: +cheryl.sabella ___ Python tracker ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Ned Deily added the comment: New changeset 122fc136b34e11906466851e77bb6959946467ee by Ned Deily in branch 'master': Revert "bpo-30487: automatically create a venv and install Sphinx when running make (GH-4346)" (#4592)

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: Yep, sounds good. -- ___ Python tracker ___ ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Ned Deily added the comment: "Now that blurb is there too, the logic for checking what is and isn't already present becomes a bit complex to reason through." Yeah, it is a bit complicated. There's also the issue of trying to use a make recipe to ensure a "venv" exists and

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: It looks like the check for an existing sphinx-build passes, and so no new venv is made, but this also means that blurb doesn't get installed. I was concerned about this, but figured that at least the buildbots would create new envs

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Change by Ned Deily : -- pull_requests: +4516 stage: needs patch -> patch review ___ Python tracker ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Zachary Ware added the comment: Go ahead with the revert, Ned. -- ___ Python tracker ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Ned Deily added the comment: One problem is that the venv can't always be automatically built in all environments, as a recent Python 3 needs to be available in the right location. -- ___ Python tracker

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: Hi Ned It's still supposed to allow both. It sounds like it's not working properly. I'll have a look. FYI, I worked on this for Zach Ware who is the primary stakeholder for this feature. Rgds Caleb > On 28 Nov 2017, at 7:12 AM,

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Ned Deily added the comment: I don't think this is a good idea. It has already caused problems with one buildbot (Issue32149) and will likely break other build scripts. As the Doc Makefile stood previous to this commit, the Doc builds could take advantage of either a

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Change by Zachary Ware : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Zachary Ware added the comment: New changeset d8d6b9122134f040cd5a4f15f40f6c9e3386db4d by Zachary Ware (Caleb Hattingh) in branch 'master': bpo-30487: automatically create a venv and install Sphinx when running make (GH-4346)

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: No worries. I've made a new PR 4346. The old one was unsalvagable I'm afraid. Too many other people got added to the notifications list as a result of my incorrect rebase. The new one is fine. --

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Change by Caleb Hattingh : -- keywords: +patch pull_requests: +4303 ___ Python tracker ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Zachary Ware added the comment: You should be able to force-push your branch (`git push -f origin auto-venv-docbuilder`, or replace `origin` with the correct remote name) to fix the existing PR. Sorry I haven't gotten back to this previously; time to do a review and

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Caleb Hattingh added the comment: I messed up the PR through a failed rebase (trying to rebase my PR on top of upstream). I closed the PR as a result. I have now fixed up my feature branch, but I have not resubmitted the PR. Since the PR was left alone for many

[issue30487] DOC: automatically create a venv and install Sphinx when running make

Changes by Mariatta Wijaya : -- stage: -> patch review ___ Python tracker ___ ___

[issue30487] DOC: automatically create a venv and install Sphinx when running make

New submission from Caleb Hattingh: Under guidance from zware during Pycon sprints, I've changed the Doc/ Makefile to automatically create a virtual environment and install Sphinx, all as part of the `make html` command. -- assignee: docs@python components: Documentation messages: