[issue30495] IDLE: modernize textview module

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue30495] IDLE: modernize textview module

Tal Einat added the comment: Ping? ISTM this could be considered done. -- nosy: +taleinat ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: I was trying to think of 2 possible future uses of ViewFrame in addition to current embedding in in ViewWindows: embedded in a tab, and tiled in a panel. With no window close [X] buttom, the button in a frame will be needed, so I left it. Since the button

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: I have some questions about the final version: 1. `ViewWindow` still has `self.button_ok` defined, but it's not used as far as I can tell. Can that be removed? 2. `def ok` in ViewFrame calls `self.parent.destroy`. I was wondering if it should be

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: New changeset 6f31717c47e325460e2a661bf44b45d342d65bcb by terryjreedy in branch '3.6': [3.6] bpo-30495: IDLE: improve textview with docstrings, PEP8 names, more tests. (GH-2283) (#2496)

[issue30495] IDLE: modernize textview module

Changes by Terry J. Reedy : -- pull_requests: +2557 ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: New changeset 42bc8beadd49f60cc52fdc397897b3bd81640406 by terryjreedy (csabella) in branch 'master': bpo-30495: IDLE: improve textview with docstrings, PEP8 names, more tests. (#2283)

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Thanks, Terry. I've pulled the textview changes out and made a PR. I know you had said there can be more than one PR for a bug, so I did it under this number. Hope that was the right thing to do. I'll take a look at help_about separately. On Mon, Jun 19,

[issue30495] IDLE: modernize textview module

Changes by Cheryl Sabella : -- pull_requests: +2331 ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: You were waiting on my review of the revised patch. 1. Remove the help_about changes. Reworking help_about is #24813. I just reviewed Mark Roseman's patch. I do not want the button frames because I would like to get rid of the buttons. Besides that, I

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Hi Terry, Were you waiting on me for changes to the patch or would you like me to make a PR? Thanks! -- ___ Python tracker

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: New changeset f3156f8f5cfb820c7deac05beba9f51ec51c by terryjreedy in branch '3.6': bpo-30495: IDLE: Modernize textview.py with docstrings and PEP8 names (#1839) (#2102) https://github.com/python/cpython/commit/f3156f8f5cfb820c7deac05beba9f51ec51c

[issue30495] IDLE: modernize textview module

Changes by Terry J. Reedy : -- pull_requests: +2156 ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: Old 2, references; my other main bookmark is the tk reference. https://www.tcl.tk/man/tcl8.6/TkCmd/contents.htm It is harder to read at first, but more complete, accurate, and up to date. Unfortunately, even it does not specify all the OS-specific divergences.

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: 1. I prefer to not deal with ttk styles yet, unless forced, and we don't seem to be here. 2. Yes, I wanted to get rid of that useless frame as part of refactoring. 3. 'self.x = x = expr' is a semi-common idiom. A local name is nice when there are multiple

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Thanks for all the info. I've made another patch for textfile.py with removing ButtonFrame. I've also included test_textfile.py and help_about.py in the patch. I had worked on help_about yesterday, so if you don't like the button classes, I may need to undo

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: Responses (without yet testing the code): 1. Generally, the only new subclass needed is for the master frame. Existing Toplevel derivatives may have a single frame in the toplevel, which should become an instance of a new subclass, in this case

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: I've attached a patch for textview for your review. Thanks for suggesting that. I still need to work on test_textview. Some comments/questions: 1. I've made the Frame classes as you suggested. I had also made a class for TextviewText (as help.py has), but

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: I believe you said elsewhere that you would like to try the refactoring that splits a window+frame class into a window class and a frame class. It would be great if you became good at doing this. If the current class name is used externally, I might consider

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: What I have learned: 1. As with hg, the local master should be updated at least at the beginning of each work session, and python.exe rebuilt. 2. Patches to master should be developed with all 'other' files updated. For completely new branches, this is

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: New changeset 0aa0a06e8b719533aefd175a5716f1698f474052 by terryjreedy (csabella) in branch 'master': bpo-30495: IDLE: Modernize textview.py with docstrings and PEP8 names (#1839) https://github.com/python/cpython/commit/0aa0a06e8b719533aefd175a5716f1698f474052

[issue30495] IDLE: modernize textview module

Cheryl Sabella added the comment: Thanks Terry! I had done a search in Spyder using "textView" and only found those files that I changed, but now I see what I did wrong. If I do it within a different git branch that isn't up to update with the master, it won't show up, but if I do it in the

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: I plan to merge when checks pass. Not reusing module names avoids noise when grepping for a module name ;-). A final search for 'textview', match case, whole word, gave 18 hits, which were easy to check. -- ___

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: Grepping shows that other references to textview objects (other than in test_textview) are to unchanged class and function names. -- ___ Python tracker

[issue30495] IDLE: modernize textview module

Terry J. Reedy added the comment: The initial patch, https://github.com/python/cpython/pull/1839, adds missing docstrings to textview and changes names to conform to PEP 8. It was originally attached to #30290. I changed the bpo # in the title to 30495. We will see if Belvedere bot corrects

[issue30495] IDLE: modernize textview module

Changes by Cheryl Sabella : -- pull_requests: +1924 ___ Python tracker ___ ___

[issue30495] IDLE: modernize textview module

New submission from Terry J. Reedy: First get issue #. -- assignee: terry.reedy components: IDLE messages: 294622 nosy: csabella, terry.reedy priority: normal severity: normal stage: patch review status: open title: IDLE: modernize textview module type: enhancement versions: Python 3.6,