[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: bpo-30536 has been marked as a duplicate of this issue: [EASY] SubinterpThreadingTests.test_threads_join_2() of test_threading leaks references. -- ___ Python tracker

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: -SET_SYS_FROM_STRING_BORROW_INT_RESULT("warnoptions", warnoptions); Oh, it seems like the regression was introduced by me in the commit 8fea252a507024edf00d5d98881d22dc8799a8d3, see: http://bugs.python.org/issue18520#msg201472 Or maybe it comes from

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

Stéphane Wirtel added the comment: I have pushed a PR, if you can check it. Thanks -- ___ Python tracker ___

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

Changes by Stéphane Wirtel : -- pull_requests: +2059 ___ Python tracker ___ ___

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: Oh, 1abcf6700b4da6207fe859de40c6c1bada6b4fec introduced two more reference leaks. -- ___ Python tracker ___

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: SubinterpreterTest.test_subinterps of test_capi also leaks. But it is likely the same bug than this issue (SubinterpreterTest.test_callbacks_leak() of test_atexit leaks). -- ___ Python tracker

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: > At the end, you should get the commit > 6b4be195cd8868b76eb6fbe166acc39beee8ce36. The commit is a giant change. So let me help you, the following change is strange. value is replaced whereas its value is non-NULL... Maybe it's the regression? ;-) diff

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: The failing unit test was added by: commit 2d350fd8af29eada0c3f264a91df6ab4af4a05fd Author: Antoine Pitrou Date: Thu Aug 1 20:56:12 2013 +0200 Issue #18619: Fix atexit leaking callbacks registered from sub-interpreters, and make it

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

Stéphane Wirtel added the comment: this issue can be executed on Linux, I think I am going to work on this one. -- nosy: +matrixise ___ Python tracker

[issue30547] [EASY][Windows] SubinterpreterTest.test_callbacks_leak() of test_atexit leaks references

STINNER Victor added the comment: I tagged this issue as easy. I consider that it's a good exercice for new contributors. Core developers: please let new contributors try to fix it since this issue is not critical, try to explain how to fix it rather than writing the fix ;-) --