[issue30640] NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx()

STINNER Victor added the comment: It's now fixed in Python 3.6 and master (3.7). FYI this issue was also detected by Coverity as CID 1415964. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue30640] NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx()

STINNER Victor added the comment: New changeset f032e9237aa7d43d21e0b04d685c36bddf7078c1 by Victor Stinner (Zackery Spytz) in branch '3.6': [3.6] bpo-30640: Fix undefined behavior in _PyFunction_FastCallDict() and PyEval_EvalCodeEx() (GH-2919) (#2964) https://github.com/python/cpython/commit/f

[issue30640] NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx()

Changes by Zackery Spytz : -- pull_requests: +3011 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30640] NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx()

Serhiy Storchaka added the comment: New changeset c6ea8974e2d939223bfd6d64ee13ec89c090d2e0 by Serhiy Storchaka (Zackery Spytz) in branch 'master': bpo-30640: Fix undefined behavior in _PyFunction_FastCallDict() and PyEval_EvalCodeEx() (#2919) https://github.com/python/cpython/commit/c6ea8974e2

[issue30640] NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx()

Zackery Spytz added the comment: As mentioned in PR 2919, this is an issue in PyEval_EvalCodeEx() as well. -- nosy: +ZackerySpytz title: NULL + 1 in _PyFunction_FastCallDict() -> NULL + 1 in _PyFunction_FastCallDict(), PyEval_EvalCodeEx() ___ Python

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

Changes by Zackery Spytz : -- pull_requests: +2972 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

Serhiy Storchaka added the comment: Yes, I mean the "k + 1" with k=NULL. Even if _PyEval_EvalCodeWithName() ignores that value, this still is an undefined behavior. For example the compiler can decide that since NULL+1 is not valid, then k never is NULL, and ignore the branch that sets k to NU

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

STINNER Victor added the comment: Can you please show me the line doing NULL+1? I don't see it. Or do you mean the "k + 1" with k=NULL? _PyEval_EvalCodeWithName() ignores kwnames and kwargs when kwcount is zero. So I don't think that the value of NULL+1 matters here :-) -- __

[issue30640] NULL + 1 in _PyFunction_FastCallDict()

Changes by STINNER Victor : -- title: NULL + 1 -> NULL + 1 in _PyFunction_FastCallDict() ___ Python tracker ___ ___ Python-bugs-list m