[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Nick Coghlan added the comment: Thanks for the technical clarification Lars, and for the docs update C.A.M. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Nick Coghlan added the comment: New changeset 89a894403cfa880d7f9d1d67070f61456d14cbde by Nick Coghlan (CAM Gerlach) in branch 'master': bpo-30661: Improve docs for tarfile pax change and effect on shutil (GH-12635)

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

C.A.M. Gerlach added the comment: Thanks for the confirmation! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Lars Gustäbel added the comment: tarfile does not use the `format` argument for reading, it will be detected. You can even mix different formats in one archive and tarfile will be fine with it. -- nosy: +lars.gustaebel ___ Python tracker

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

C.A.M. Gerlach added the comment: I opened a PR to implement both those changes, and also added some minor related clarifications and fixes to the format section of the tarfile docs. > how tarfile.Tarfile behaves if you tell it to open a PAX_FORMAT archive using > GNU_FORMAT or vice-versa

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Change by C.A.M. Gerlach : -- pull_requests: +12566 stage: needs patch -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Nick Coghlan added the comment: Aye, I agree that changing the default resolves the feature request here. I've recategorised this as a documentation issue, as the initial PR only changed the `tarfile` documentation, so the impact on `shutil` isn't obvious. So the changes needed will be: *

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Change by C.A.M. Gerlach : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

C.A.M. Gerlach added the comment: FYI, [GH-12355](https://github.com/python/cpython/pull/12355) will implement pax as default, as discussed in [bpo-36268](https://bugs.python.org/issue36268), which should be equivalent to option 1 here, thus also resolving this issue. Could you confirm that

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Change by C.A.M. Gerlach : -- keywords: +patch pull_requests: +12321 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

Nick Coghlan added the comment: The main benefit I'd see to the last option is that it would also cover passing a "filter" option for tarfile.TarFile.add(). Dropping down to the lower level API for that isn't *hard*, it's just a bit fiddly (note: currently untested example code): sdist =

[issue30661] Support tarfile.PAX_FORMAT in shutil.make_archive

New submission from Nick Coghlan: shutil.make_archive currently just uses the default tar format, which is GNU_FORMAT. This format doesn't ensure that all character paths are encoded as UTF-8, and hence may end up embedding platform specific encoding assumptions into the generated tarball.