[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Change by Eric Snow : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Masayuki Yamamoto : -- pull_requests: +2652 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Antoine Pitrou : -- stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list m

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: New changeset 3024c0529077f5cff0b32dc84b5923c8fba99a87 by Antoine Pitrou in branch '3.6': [3.6] bpo-30703: Improve signal delivery (GH-2415) (#2527) https://github.com/python/cpython/commit/3024c0529077f5cff0b32dc84b5923c8fba99a87 --

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Antoine Pitrou : -- pull_requests: +2592 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: Thanks for running such a lengthy test, Matt :-) -- ___ Python tracker ___ ___ Python-bugs-list mail

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

STINNER Victor added the comment: I concur with Matt: nice job Antoine, thanks for making Python more reliable ;-) -- ___ Python tracker ___ _

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Matt Billenstein added the comment: Verified this by letting the test_many_processes loop overnight (master@42bc8beadd49)-- 34k passes later and no hangs. Nice work! -- ___ Python tracker

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: I will wait a bit and then backport this to 3.6. -- resolution: -> fixed stage: patch review -> backport needed versions: +Python 3.6 ___ Python tracker __

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: New changeset c08177a1ccad2ed0d50898c2731b518c631aed14 by Antoine Pitrou in branch 'master': bpo-30703: Improve signal delivery (#2415) https://github.com/python/cpython/commit/c08177a1ccad2ed0d50898c2731b518c631aed14 -- _

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: For the record, https://github.com/python/cpython/pull/2415 is ready. -- ___ Python tracker ___ ___

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Antoine Pitrou : -- pull_requests: +2473 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Kristján Valur Jónsson added the comment: Thanks for the mention, @pitrou. CCP was using Py_AddPendingCall but not from signal handlers, but external threads. Also on windows only. You'll also be happy to know that I have left CCP and the Eve codebase is being kept stable while regularly addin

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Antoine Pitrou : -- dependencies: -Make CHECK_STATUS_PTHREAD signal-safe, PyThread_acquire_lock can block even when asked not ot ___ Python tracker ___ _

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by Antoine Pitrou : -- stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: It seems https://github.com/python/cpython/pull/2408 alone solves the issue on Matt's machine. It's also a pleasantly simple patch :-) -- ___ Python tracker _

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Antoine Pitrou added the comment: I think Kristjan uses Py_AddPendingCall, so ideally we would make it more reliable. However, we're right that for the purpose of signal delivery, we can hardcall a call inside Py_MakePendingCalls(). -- nosy: +kristjan.jonsson

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by STINNER Victor : -- pull_requests: +2456 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30703] Non-reentrant signal handler (test_multiprocessing_forkserver hangs)

Changes by STINNER Victor : -- title: test_multiprocessing_forkserver hangs on the master branch -> Non-reentrant signal handler (test_multiprocessing_forkserver hangs) ___ Python tracker _