[issue30710] getaddrinfo raises OverflowError

Rémi Lapeyre added the comment: Hi Cheryl Sabella, the pull request that got closed is the one for issue 30711. The pull request for this one has never been reviewed. -- nosy: +remi.lapeyre ___ Python tracker __

[issue30710] getaddrinfo raises OverflowError

Cheryl Sabella added the comment: The original pull request has been closed as inactive. If the original author is interested in pursuing this issue, it can be reopened or someone else can create a new pull request to replace it. -- nosy: +cheryl.sabella ___

[issue30710] getaddrinfo raises OverflowError

Changes by Radek Smejkal : -- pull_requests: +2483 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30710] getaddrinfo raises OverflowError

Radek Smejkal added the comment: > I like your idea about getting rid of OverflowError. But wouldn't it make the > problem with other reported by you issue, issue30711, worse? It depends on the implementation of the underlying getaddrinfo. For Modules/getaddrinfo.c, it will be worse for positi

[issue30710] getaddrinfo raises OverflowError

Radek Smejkal added the comment: > Why can't the user simply pass in a string service name in the first place? He/she can. But I don't propose to change that. The patch only changes the way a given number is converted to a string. That is, without an intermediate C long. -- __

[issue30710] getaddrinfo raises OverflowError

Serhiy Storchaka added the comment: I like your idea about getting rid of OverflowError. But wouldn't it make the problem with other reported by you issue, issue30711, worse? -- ___ Python tracker

[issue30710] getaddrinfo raises OverflowError

Radek Smejkal added the comment: > But how large is the performance hit of this change? It adds at least one > additional memory allocation for the str object. If the slowdown is > significant perhaps it is worth to keep the old code as a fast path. commit 5cc7ac24da10568d2a910a91a24183b904118

[issue30710] getaddrinfo raises OverflowError

Benjamin Peterson added the comment: Why can't the user simply pass in a string service name in the first place? -- nosy: +benjamin.peterson ___ Python tracker ___ __

[issue30710] getaddrinfo raises OverflowError

Serhiy Storchaka added the comment: Now I understand your idea. It looks reasonable to me. Could you create a pull request on GitHub? Please provide also tests, add a Misc/NEWS entry and add your name in Misc/ACKS. But how large is the performance hit of this change? It adds at least one addi

[issue30710] getaddrinfo raises OverflowError

Radek Smejkal added the comment: Use PyObject_Str and PyUnicode_AsUTF8 if the port argument is a PyLong instead of converting it to an intermediate C long that may raise OverflowError. See getaddrinfo_overflow_error.patch -- components: +Extension Modules -Library (Lib) keywords: +patc

[issue30710] getaddrinfo raises OverflowError

Serhiy Storchaka added the comment: What do you mean by converting the port to a string (bytes) directly? Can you provide an example? -- nosy: +serhiy.storchaka ___ Python tracker _

[issue30710] getaddrinfo raises OverflowError

New submission from Radek Smejkal: If the port argument is a number, getaddrinfo attempts to convert it to a C long, that raises OverflowError if the conversion fails. Instead, getaddrinfo should convert the port to a string (bytes) directly and rely on the underlying getaddrinfo to return EAI