[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset c0179483f13be81910ed73889dcad92528e20ef2 by terryjreedy in branch '3.6': [3.6] bpo-30779: IDLE: fix changes.delete_section calls in configdialog (GH-2667) (#2674) https://github.com/python/cpython/commit/c0179483f13be81910ed73889dcad92528e20ef2

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2742 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset 6d13b22e3ab262c6b1f068259aebd705e7da316c by terryjreedy (csabella) in branch 'master': bpo-30779: IDLE: fix changes.delete_section calls in configdialog (#2667) https://github.com/python/cpython/commit/6d13b22e3ab262c6b1f068259aebd705e7da316c --

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Eventually, we will have tests that would have caught this. I took the opportunity to improve the test for the call. -- ___ Python tracker ___

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I had an error when trying to delete a custom theme. Sorry for not catching this before. -- ___ Python tracker ___ ___

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2733 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset 9d8abf31c430dd83d073660cc92f1fe4ca6f2cd4 by terryjreedy in branch '3.6': [3.6] bpo-30779: News (GH-2627) (#2630) https://github.com/python/cpython/commit/9d8abf31c430dd83d073660cc92f1fe4ca6f2cd4 -- __

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2695 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2693 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset 24f2e19d68cc6ca563d2be5944d11d5f55a46918 by terryjreedy in branch 'master': bpo-30779: News (#2627) https://github.com/python/cpython/commit/24f2e19d68cc6ca563d2be5944d11d5f55a46918 -- ___ Python trac

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- resolution: -> fixed stage: test needed -> resolved status: open -> closed ___ Python tracker ___ ___

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Cheryl, thank you for reviewing. I am answering the question about #30868 on that issue. I did not want to immediately test user parser Save() calls in the .save_all test for two reasons. 1. I want to first reconsider the general question what to do about Sa

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset edc034221f878b437748cef0f05c782d8190499d by terryjreedy in branch '3.6': [3.6] bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test. (GH-2612) (#2625) https://github.com/python/cpython/commit/edc034221f878b437748ce

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2691 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: New changeset 349abd9e37dfdc077bc21f19e6ed2292c767f0e8 by terryjreedy in branch 'master': bpo-30779: IDLE -- Factor ConfigChanges class from configdialog, put in config; test. (#2612) https://github.com/python/cpython/commit/349abd9e37dfdc077bc21f19e6ed2292c76

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Terry, Any interest on using gitter or slack (or something like that) while trying to coordinate work between you, Louie, me, and others? -- ___ Python tracker __

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Sorry about that. When I read msg297804, I thought your intention was for me to work on the PRs. I didn't see your other note until now. It will be good for me to learn from your changes. As far as mocking Save, I sort of did that (very basically) in my PR

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Whoops, we seems to have partly overlapped (and made some of the same changes). I plan to push my PR sometime tomorrow (it also changes configdialog and revised tests) after looking as yours. Then move on to adding config tests, #30780. The tests for config

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- pull_requests: +2677 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: I've made the first pull request for the changes to config.py. I have to apologize because I really couldn't figure out how to do 'save_all' without including 'set_user_value' since 'set_user_value' updates userCfg with the values from ConfigChanges. Also, i

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : -- pull_requests: +2675 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: I am working on this now. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Comments on difficulties and questions. D1. I will look at test changes where there is a PR to run. I wrote what you changed, but might not have considered what you did. D2. Moot for the moment. D3. Ditto. D4. If not needed, skip for now. D5. I will be more co

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: To get moving and unblock other issues, I decided to start with the simplest not-bad change that will work. The factored out code belongs in config.py. This will separate integration with ConfigDialog into 2 steps. 1. Add code and tests to config and test_conf

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Thanks for pointing out mapping protocol access. That's what I was (poorly) trying to describe in the __getitem__ docstring in v1. It's a really concept. I worked on the tests. I added some more code to the classes, so I uploaded that too (sorry, but I need

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : Added file: http://bugs.python.org/file46985/changes_class_v3.py ___ Python tracker ___ ___ Python-bugs-list maili

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Cheryl Sabella : Added file: http://bugs.python.org/file46984/configdialog_tests_v1.py ___ Python tracker ___ ___ Python-bugs-list

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: The question about reusing ConfigParser (or IdleConfigParser) was a good one. I spent at least an hour looking again at the code and configparser doc. Observations: 1. Dropping 2.7 support allows us to use mapping protocol access: https://docs.python.org/3/lib

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: Here's the beginning design. Since it's a high priority, I didn't want to wait too long to show you something. As you can see, I still had a lot of questions and things I wasn't sure about. I have some tests, but wanted to have it more complete before submit

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: High, because other issues depend on this. -- priority: normal -> high ___ Python tracker ___ ___ Py

[issue30779] IDLE: configdialog -- factor out Changes class

Terry J. Reedy added the comment: Let's do it 'right'. Step 1: Write class design in the form of a class with methods with APIs and docstrings as the bodies. class Changes: """Manage a user's proposed configuation option changes. Changes are either cancelled or applied in a single trans

[issue30779] IDLE: configdialog -- factor out Changes class

Cheryl Sabella added the comment: If possible, I'd like to work on this. -- nosy: +csabella ___ Python tracker ___ ___ Python-bugs-lis

[issue30779] IDLE: configdialog -- factor out Changes class

Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE ___ Python tracker ___ ___ Python-bugs-list mailing list Un

[issue30779] IDLE: configdialog -- factor out Changes class

New submission from Terry J. Reedy: configdialog.ConfigDialog mixes together two things: a user interface for changing options and a mechanism for storing proposed changes and applying them to the configuration dictionaries managed by config. The change mechanism is based on a 3-level dict t