[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

miss-islington added the comment: New changeset 7b57b15bd83879ee35f8758a84a7857a9968c145 by Miss Islington (bot) in branch '3.8': bpo-30780: Add IDLE configdialog tests (GH-3592) https://github.com/python/cpython/commit/7b57b15bd83879ee35f8758a84a7857a9968c145 --

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

miss-islington added the comment: New changeset 5aefee6f989821c5dc36d10a9cfd083d7aa737a5 by Miss Islington (bot) in branch '3.7': bpo-30780: Add IDLE configdialog tests (GH-3592) https://github.com/python/cpython/commit/5aefee6f989821c5dc36d10a9cfd083d7aa737a5 -- nosy:

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Change by miss-islington : -- pull_requests: +17599 pull_request: https://github.com/python/cpython/pull/18219 ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Change by miss-islington : -- pull_requests: +17598 pull_request: https://github.com/python/cpython/pull/18218 ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: New changeset dd023ad1619b6f1ab313986e8953eea32c18f50c by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-30780: Add IDLE configdialog tests (#3592) https://github.com/python/cpython/commit/dd023ad1619b6f1ab313986e8953eea32c18f50c --

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: Review of overview: PR-2706 and PR-2613 fixed one line in test_configdialog for this issue. PR-2046, #30617 and PR-3238, #30781 are merged cross-references. PR-3222 was closed in favor of PR-3220, #31287, merged. PR-3592 completes highlights

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Cheryl Sabella added the comment: I've submitted a PR for the tests that I added to complete coverage for Keys and Highlights and to add some GUI tests for the buttons. It's not everything that I wanted to do, but it ended up being more substantial than I realized. Here's the issue I was

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Cheryl Sabella : -- pull_requests: +3583 ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Cheryl Sabella added the comment: Sorry I don't have any tests yet. I've added a few, but it's taking me forever to figure out the bindings for testing the `Double-Button-1` and `B1-Motion`. I actually have a test for `Double-Button-1` now, but still working on `B1-Motion`. --

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: Entry tests should delete before insert. ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: I just pushed the extension conversion patch. The tests we did already were greatly helpful, and some tests not done or inadequate hindered. I am now looking to polish configdialog before 3.6.3. If you have anything worth a new issue and PR, I will be

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Cheryl Sabella : -- keywords: +patch pull_requests: +3480 stage: test needed -> patch review ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Cheryl Sabella added the comment: I've started working on the missing tests for HighPage and KeysPage and also test for the functions and buttons in ConfigDialog. That led to PR3238 because the 'help' button wasn't working. Anyway, I found the following on

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Cheryl Sabella : -- pull_requests: +3264 ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: #31001 and #31002 have notes on what not tested in HighPage and KeysPage. -- ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE tests: don't modify tkinter.messagebox. nosy: +csabella ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Cheryl Sabella : -- pull_requests: +3255 ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: This issue is almost done. There are just a few things missed by the closed dependencies. -- ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: Add tests for configdialog highlight tab, IDLE: Add tests for configdialog keys tab, IDLE: Add tests for help sources on configdialog general tab ___ Python tracker

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: Document and fix configdialog font tests. ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: Add config dialog font page tests ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- dependencies: +IDLE: configdialog/fonts: change font when select by key up/down ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: New changeset df0f99329843c10701ffaefbd3948ac698c12220 by terryjreedy in branch '3.6': [3.6] bpo-30780: Fix error in idlelib.test_idle.test_configdialog (GH-2606) (#2613) https://github.com/python/cpython/commit/df0f99329843c10701ffaefbd3948ac698c12220

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- pull_requests: +2678 ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: I posted PR 2612 for #30779 and expect to merge it tomorrow after sleep and final review. It includes passing revisions of existing configdialog tests. A PR dependent on 2612 could be posted before I do the merge. Follow the model of using xyzpage names in

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: New changeset 25a4206c243e3b1fa6f5b1c72a11b409b007694d by terryjreedy in branch 'master': bpo-30780: Fix error in idlelib.test_idle.test_configdialog (#2606) https://github.com/python/cpython/commit/25a4206c243e3b1fa6f5b1c72a11b409b007694d --

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: PR to fix type in moduleTearDown. -- ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- pull_requests: +2673 ___ Python tracker ___ ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: Proceed as you want. Keep in mind that the interface to the changes structure will be changed by #30779. The testing logic should not be, however. -- ___ Python tracker

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Louie Lu added the comment: I'm trying to add the test on configdialog, currently working on KeysTest. -- nosy: +louielu ___ Python tracker ___

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Terry J. Reedy added the comment: Tests should be tested on MacOS before being pushed. A possible issue is including constants that are different on different systems. See #28572 -- ___ Python tracker

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

New submission from Terry J. Reedy: A complete test of the GUI will simulate user interaction with every widget and then query Changes() to see that the proper changes orders have been recorded. This issue depends on #30779, factor out Changes class. -- messages: 296963 nosy:

[issue30780] IDLE: configdialog - add tests for ConfigDialog GUI.

Changes by Terry J. Reedy : -- assignee: -> terry.reedy components: +IDLE dependencies: +IDLE: configdialog -- factor out Changes class ___ Python tracker