[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 3892799668dbf2b123a52780fd1d78f8880fdeb7 by Victor Stinner (Miss Islington (bot)) in branch '3.6': [3.6] bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (GH-2534) (#3405) https://github.com/python/cpython/commit/3892799668dbf2b123a5

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Roundup Robot : -- pull_requests: +3408 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: > Secretly, I'm just happy that my legacy will not be a commit which broke all > (?) the build-bots and had to be reverted. :P Reverting is a new policy that we decided last June: https://mail.python.org/pipermail/python-committers/2017-June/004588.html Sorry

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: Thanks Victor! \o/ Secretly, I'm just happy that my legacy will not be a commit which broke all (?) the build-bots and had to be reverted. :P W.r.t. the docs; in retrospect, that'll probably have a larger impact on the end-users and is less likely to cause

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: Ok, I merged the change in the 3.6 branch. I decided to not merge the 3.5 change, since it's now too late: 3.5 slowly enters a new security-only fixes: https://github.com/python/cpython/pull/2815 Thanks Utkarsh Upadhyay for your work on datetime, not only this

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset c52cea49544621b612c7f17f45a0c2b8b61a6c67 by Victor Stinner (Utkarsh Upadhyay) in branch '3.6': [3.6] bpo-30822: Fix testing of datetime module. (GH-2530) (GH-2783) (#2816) https://github.com/python/cpython/commit/c52cea49544621b612c7f17f45a0c2b8b6

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2868 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2867 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: Utkarsh comment on the PR: > I'm afraid I don't really know how to read the waterfall chart at > http://buildbot.python.org/all/waterfall. Yeah, sorry about this awful view :-) We now have a mailing list getting notifications when a buildbot fails: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 287c5594edc1ca08db64d1f4739cc36bfe75ae75 by Victor Stinner (Utkarsh Upadhyay) in branch 'master': bpo-30822: Fix testing of datetime module. (#2530) (#2783) https://github.com/python/cpython/commit/287c5594edc1ca08db64d1f4739cc36bfe75ae75 --

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 80ebc438ed377f8c6491e8887425526c6787c0e7 by Victor Stinner in branch '2.7': bpo-30822: regrtest: fix -u extralargefile (#2788) https://github.com/python/cpython/commit/80ebc438ed377f8c6491e8887425526c6787c0e7 --

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2838 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2834 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset bf3a1e973b49236e6f267cca135d36290568e6a4 by Victor Stinner in branch '3.5': bpo-30822: regrtest: remove tzdata (#2782) https://github.com/python/cpython/commit/bf3a1e973b49236e6f267cca135d36290568e6a4 --

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: (Oops, I gone too fast in my 3.5 backport. tzdata was only introduced in Python 3.6, for me it was something older. I wrote a new fix for 3.5, to only add extralargefile, but don't add tzdata.) -- ___ Python tracker

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2833 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 645e503ba58086c7f51eda4d025743f2afc05a2a by Victor Stinner in branch '3.5': bpo-30822: Exclude tzdata from regrtest --all (#2775) (#2781) https://github.com/python/cpython/commit/645e503ba58086c7f51eda4d025743f2afc05a2a -- _

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 96ef06f3979023fd69ed8796d0b1d5d3ae4d by Victor Stinner in branch '3.6': bpo-30822: Exclude tzdata from regrtest --all (#2775) (#2777) https://github.com/python/cpython/commit/96ef06f3979023fd69ed8796d0b1d5d3ae4d -- _

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2832 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2831 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 5b392bbaeb9d9b1db961ecfc7315d8c8662c27f6 by Victor Stinner in branch 'master': bpo-30822: Exclude tzdata from regrtest --all (#2775) https://github.com/python/cpython/commit/5b392bbaeb9d9b1db961ecfc7315d8c8662c27f6 -- __

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: Serhiy Storchaka: "If testing with -u tzdata is such expensive, tzdata can be excluded from all resources." I agree, I wrote a PR for that: https://github.com/python/cpython/pull/2775 I like using "-u all" without having to remind that a specific resource (tz

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2829 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: So it seems that running the experiments without `-utzdata` would be an acceptable fix (assuming that there are no other interesting time-zones worthy of explicit testing)? Can I help in the resolution of this issue, since resolution of http://bugs.python.o

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: If testing with -u tzdata is such expensive, tzdata can be excluded from all resources. There is a precedence with the extralargefile resource (see test_zipfile64). Actually this means that these test will never run until you request this specially. --

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: > Two timezones (America/New_York and Asia/Tehran) are picked for testing > independently from the -utzdata flag. By the way, if someone is aware of other interesting timezones, we may also test more timezones (without tzdata)? -- ___

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: I reverted the commit which fixes test_datetime to also test Lib/datetime.py, to repair buildbots. But since I reverted the change, nothing was done so datetime.py is still not tested :-( > The tests enabled by "-utzdata" check UTC to local and back conversion

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Two timezones (America/New_York and Asia/Tehran) are picked for testing independently from the -utzdata flag. -- ___ Python tracker ___ _

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: > These tests were supposed to be exhaustive and I did not expect them to be > run by default. that's why I introduced the -utzdata flag in the first place. Buildbots use "-u all" and so enables tzdata tests. Is it useful to run all these tests on all branches

[issue30822] Python implementation of datetime module is not being tested correctly.

Alexander Belopolsky added the comment: > Why is it so slow? The tests enabled by "-utzdata" check UTC to local and back conversions at several points around *every* time transition in *every* timezone. On systems with a complete installation of IANA tzdata, this is a lot of test points. Thes

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: > Another solution -- disable "cpu" and "tzdata" resources on slow buildbots > (see issue30417). I didn't read test_datetime. How test_datetime can spend 20 minutes to test timestamps? Does it spawn subprocesses? Why is it so slow? -- ___

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: I reverted the change to repair buildbots and get more time to find a proper fix: https://github.com/python/cpython/pull/2588#issuecomment-313092304 -- ___ Python tracker

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: New changeset 8207c17486baece8ed0ac42d9f8d69ecec4ba7e4 by Victor Stinner in branch 'master': Revert "bpo-30822: Fix testing of datetime module." (#2588) https://github.com/python/cpython/commit/8207c17486baece8ed0ac42d9f8d69ecec4ba7e4 --

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Another solution -- disable "cpu" and "tzdata" resources on slow buildbots (see issue30417). -- ___ Python tracker ___ __

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by STINNER Victor : -- pull_requests: +2658 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: It's not just a matter of making test_datetime "faster". I see it as a regression, since now it fails randomly on slow buildbots. Maybe we should revert the change until a solution is found. http://buildbot.python.org/all/builders/ARMv7%20Ubuntu%203.x/builds/1

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: I would prefer to make test_datetime faster in master before backporting. -- ___ Python tracker ___

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2621 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2620 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Let discuss too long time of testing datetime time zones in separate issue. -- ___ Python tracker ___

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: Hmm, I don't know if testing every zone is necessary. However, I would not be comfortable picking out the zones one ought to test, considering: if ('Riyadh8' in self.zonename or # From tzdata NEWS file: # The files solar87, so

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: > Running the tests take ~ 10 minutes on my system with -utzdata enabled; 19 > minutes does sound like a bit much but I'm not aware of the specs of the > buildbot machines. I don't consider that 10 minutes to test the small datetime module is a reasonable dur

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: Previously, test_datetime was running only `_Fast` tests (i.e. testing the C module). Then (because of an erring commit from me), testing for `_Pure` implementation started but all tests per time-zone started running thrice instead of once. Hence, the timeou

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: Oh, I didn't read the issue. In fact, it seems like the commit 34b54873b51a1ebee2a3c57b7205537b4f33128d already repaired buildbots (x86 Tiger 3.x at least). But... test_datetime became the *slowest* test of x86 Tiger 3.x: 10 slowest tests: - test_datetime: 19

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: http://buildbot.python.org/all/builders/ARMv7%20Ubuntu%203.x/builds/1013/steps/test/logs/stdio test_gaps (test.datetimetester.ZoneInfoTest[Europe/Riga]_Pure_Pure_Pure) ... ok test_system_transitions (test.datetimetester.ZoneInfoTest[Europe/Riga]_Pure_Pure_Pure

[issue30822] Python implementation of datetime module is not being tested correctly.

STINNER Victor added the comment: Regression: http://buildbot.python.org/all/builders/PPC64%20Fedora%203.x/builds/1000/steps/test/logs/stdio test_system_transitions (test.datetimetester.ZoneInfoTest[America/Juneau]_Pure_Pure_Pure) ... Timeout (0:15:00)! Thread 0x3fffa9aa5a20 (most recent

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Good point! But datetimetester uses the implementation depending on the availability of the _datetime extension module. If it is not available, the pure Python implementation is used, and other tests are failed. I think it would be better to fix first the i

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: Hmm, I see; I did not know that. I had just assumed that `./python -m test test_*` was the standard command for running tests. However, if one does run tests using standalone `datetimetester` (which only imports the _Fast C extension module), then I'll have

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: > This is confirmed by changing the code to the following: Yes, this is other way to fix test_datetime. But this breaks running tests via datetimetester: ./python -m test -vuall datetimetester -- ___ Python tr

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: So the problem is occurring because a single `Test` class is being instantiated with three different tests here in datetimetester.py: for name in ZoneInfo.zonenames(): Test = type('ZoneInfoTest[%s]' % name, (ZoneInfoTest,), {})

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: New changeset 34b54873b51a1ebee2a3c57b7205537b4f33128d by Serhiy Storchaka in branch 'master': bpo-30822: Deduplicate ZoneInfoTest classes in test_datetime. (#2534) https://github.com/python/cpython/commit/34b54873b51a1ebee2a3c57b7205537b4f33128d --

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: > Are there any guides re: backporting commits? > > Just to confirm verify that I'm going about it right; I’m planning on > cherry-picking relevant commits back to branch 3.5, 3.6, resolving the merge > conflicts, and then opening two separate PRs for them wi

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: The quick solution -- just deduplicate test classes. But the code needs rewriting. Current code is tricky and fragile. It doesn't work with --list-cases (and I suppose it doesn't work well with other advanced unittest features). This would be not easy.

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Serhiy Storchaka : -- pull_requests: +2601 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Serhiy Storchaka : -- assignee: -> serhiy.storchaka nosy: +belopolsky ___ Python tracker ___ ___ Python-bugs-list mailing

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: I can reproduce the names with `_Pure_Pure_Pure` if I run the tests with `-utzdata`. Investigating. ~ ut -- ___ Python tracker ___ _

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Oh, test.datetimetester.ZoneInfoTest[Europe/Andorra]_Pure_Pure_Pure -- something looks wrong. -- ___ Python tracker ___ _

[issue30822] Python implementation of datetime module is not being tested correctly.

Ned Deily added the comment: Serhiy, it appears that the added tests are taking a long time to run and thus causing many buildbot failures, for example: http://buildbot.python.org/all/builders/ARMv7%20Ubuntu%203.x/builds/1013 -- nosy: +ned.deily ___

[issue30822] Python implementation of datetime module is not being tested correctly.

Utkarsh Upadhyay added the comment: Are there any guides re: backporting commits? Just to confirm verify that I'm going about it right; I’m planning on cherry-picking relevant commits back to branch 3.5, 3.6, resolving the merge conflicts, and then opening two separate PRs for them with `bpo-3

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Serhiy Storchaka : -- stage: needs patch -> backport needed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: New changeset 98b6bc3bf72532b784a1c1fa76eaa6026a663e44 by Serhiy Storchaka (Utkarsh Upadhyay) in branch 'master': bpo-30822: Fix testing of datetime module. (#2530) https://github.com/python/cpython/commit/98b6bc3bf72532b784a1c1fa76eaa6026a663e44 --

[issue30822] Python implementation of datetime module is not being tested correctly.

Changes by Utkarsh Upadhyay : -- pull_requests: +2597 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://m

[issue30822] Python implementation of datetime module is not being tested correctly.

Serhiy Storchaka added the comment: Please provide a separate PR for this. After merging it with the master branch it should be backported to 3.6 and 3.5 (3.4 and 3.3 are for security only fixes). Add your name in Misc/ACKS. Changes in Misc/NEWS.d/ are not required. -- stage: -> needs

[issue30822] Python implementation of datetime module is not being tested correctly.

New submission from Utkarsh Upadhyay: While investigating http://bugs.python.org/issue30302 it was discovered that the Python implementation of the datetime module was not being tested correctly. The datetimetester.py was supposed to execute tests twice, once for the _Fast implementation (i.e.