[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: PR2769 is the fix for master for test_get_font for #30968. The listing here is a cross-reference. The fix was incorporated into the 3.6 backport PR2753 before it was merged. This issue is closed, having increased coverage from 46% to 96%. Further work on c

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: New changeset 65c24c846797b93d7adb72fc400f95a570f43fa9 by terryjreedy in branch '3.6': [3.6] bpo-30917: IDLE: Add config.IdleConf unittests (GH-2691) (#2753) https://github.com/python/cpython/commit/65c24c846797b93d7adb72fc400f95a570f43fa9 -- ___

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Changes by Terry J. Reedy : -- pull_requests: +2828 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: New changeset ed014f7e135fe021837208960237d6c37afde5be by terryjreedy (Louie Lu) in branch 'master': bpo-30917: IDLE: Fix mock_config deepcopy to read_string (#2754) https://github.com/python/cpython/commit/ed014f7e135fe021837208960237d6c37afde5be --

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

STINNER Victor added the comment: Please see bpo-30968: "test_get_font (idlelib.idle_test.test_config.IdleConfTest) failure on x86 Windows7 3.x". -- nosy: +haypo ___ Python tracker

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: Thanks. I will look at it tomorrow and if it seems ok, prepare a new combined backport and see if it passes. -- ___ Python tracker ___ ___

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Louie Lu added the comment: PR 2754 changed it to use `read_string`. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Changes by Louie Lu : -- pull_requests: +2813 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: The deepcopy does not work on 3.6. Any fix should be applied to 3.7 as well. If nothing else, we should try to reload with read_string. This is a blocker for merging anything else into config and test_config. -- _

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Changes by Terry J. Reedy : -- pull_requests: +2812 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: New changeset f776eb0f0e046f2fa3a96540bb42d8cf970f6c55 by terryjreedy (Louie Lu) in branch 'master': bpo-30917: IDLE: Add config.IdleConf unittests (#2691) https://github.com/python/cpython/commit/f776eb0f0e046f2fa3a96540bb42d8cf970f6c55 -- _

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: Whatever is merged with PR_2691, further improvements can be made in further PRs either on this issue or others that work on config code. I still think this test is slower than it should be -- the change to deep copy either made no difference or made it slow

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Terry J. Reedy added the comment: Yes, go ahead next with name changes and use of modern features such as sets and comprehensions. Please discuss 'general changes before coding. When we added Linux Modern keys a year ago, I combined two functions into IdleConf.current_colors_and_keys. I sus

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Louie Lu added the comment: After this unittest is merged, I would like to first cleanup config.py source code, then modify it more general way. -- ___ Python tracker ___ __

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

Changes by Louie Lu : -- pull_requests: +2755 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30917] IDLE: Add idlelib.config.IdleConf unittest

New submission from Louie Lu: Add idlelib.config.IdleConf unittest. -- assignee: terry.reedy components: IDLE messages: 298266 nosy: louielu, terry.reedy priority: normal severity: normal status: open title: IDLE: Add idlelib.config.IdleConf unittest versions: Python 3.6, Python 3.7 ___