[issue30974] Update os.samefile docstring to match documentation

Change by Steve Dower : -- resolution: -> fixed stage: backport needed -> resolved status: open -> closed ___ Python tracker ___ __

[issue30974] Update os.samefile docstring to match documentation

Irit Katriel added the comment: Since backport to 2.7 is no longer relevant, I think this issue can be closed. -- nosy: +iritkatriel ___ Python tracker ___ ___

[issue30974] Update os.samefile docstring to match documentation

miss-islington added the comment: New changeset a49f203e052c6fb1244d4e55c3fccc439dda0e2e by Miss Islington (bot) in branch '3.7': bpo-30974: Change os.path.samefile docstring to match docs (GH-7337) https://github.com/python/cpython/commit/a49f203e052c6fb1244d4e55c3fccc439dda0e2e --

[issue30974] Update os.samefile docstring to match documentation

miss-islington added the comment: New changeset 6b833901fe9053937c289c6371bb731c9aceb58e by Miss Islington (bot) in branch '3.8': bpo-30974: Change os.path.samefile docstring to match docs (GH-7337) https://github.com/python/cpython/commit/6b833901fe9053937c289c6371bb731c9aceb58e --

[issue30974] Update os.samefile docstring to match documentation

Steve Dower added the comment: Still needs a 2.7 backport if someone would like to do it. -- ___ Python tracker ___ ___ Python-bugs

[issue30974] Update os.samefile docstring to match documentation

Steve Dower added the comment: I'm not personally thrilled about it being documented like this, but it's certainly how the current documentation reads. Consistency is better until we get motivated enough to fix all of it. Thanks for the patch! -- stage: patch review -> backport need

[issue30974] Update os.samefile docstring to match documentation

Change by miss-islington : -- pull_requests: +14831 pull_request: https://github.com/python/cpython/pull/15086 ___ Python tracker ___ __

[issue30974] Update os.samefile docstring to match documentation

Change by miss-islington : -- pull_requests: +14832 pull_request: https://github.com/python/cpython/pull/15087 ___ Python tracker ___ __

[issue30974] Update os.samefile docstring to match documentation

Steve Dower added the comment: New changeset 8e568ef266a2805f9a6042003723d9c050830461 by Steve Dower (Timo Furrer) in branch 'master': bpo-30974: Change os.path.samefile docstring to match docs (GH-7337) https://github.com/python/cpython/commit/8e568ef266a2805f9a6042003723d9c050830461 -

[issue30974] Update os.samefile docstring to match documentation

Change by Steve Dower : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue30974] Update os.samefile docstring to match documentation

Steve Dower added the comment: I think the docs are too specific about the mechanism used here - if we document *how* it works then we may not be able to make it work correctly (with a different mechanic) on a different platform. -- nosy: +steve.dower ___

[issue30974] Update os.samefile docstring to match documentation

Steve Dower added the comment: Sorry, I meant the docs after the patch. Before, it's fine. -- ___ Python tracker ___ ___ Python-bug

[issue30974] Update os.samefile docstring to match documentation

Change by Timo Furrer : -- keywords: +patch pull_requests: +6968 stage: needs patch -> patch review ___ Python tracker ___ ___ Pytho

[issue30974] Update os.samefile docstring to match documentation

Change by Cheryl Sabella : -- keywords: +easy stage: -> needs patch versions: +Python 3.8 -Python 3.6 ___ Python tracker ___ ___ Pyt

[issue30974] Update os.samefile docstring to match documentation

R. David Murray added the comment: I would take "actual file" as meaning the file the symlink points to, so I'd say the documentation matches the implementation according to your description of the two. The current docs actually say "refer to the same file or directory", and mention os.stat e