[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: Idlelib is a bit exceptional: see PEP 434. Except for one test and the news files, I keep idlelib identical in 3.6 and 3.7. This makes all backports, *including new tests*, trivial and overall reduces the risk of regression (unless IDLE 3.6 were abandoned co

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

STINNER Victor added the comment: By the way, I suggest to not backport refactoring changes to stable branches like Python 3.6. Any refactoring is a risk of regressions. Well, it's just an advice, Terry knows IDLE much better than me ;-) It's up to you to decide to backport or not such change.

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

STINNER Victor added the comment: > New changeset 9397e2a87ed6e0e724ad71a0c751553620cb775e by Terry Jan Reedy > (csabella) in branch 'master': > bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1) (#2905) This change introduced reference leaks in test_idle: see bpo-31130. ---

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: At last! On to the next one. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ _

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: New changeset 7582226a92481ca63dedbfe14ef465d1349d66a9 by Terry Jan Reedy in branch '3.6': [3.6] bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1) (GH-2905) (#2950) https://github.com/python/cpython/commit/7582226a92481ca63dedbfe14ef465d134

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Changes by Terry J. Reedy : -- pull_requests: +2999 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: New changeset 9397e2a87ed6e0e724ad71a0c751553620cb775e by Terry Jan Reedy (csabella) in branch 'master': bpo-31004: IDLE: Factor out FontPage class from configdialog (step 1) (#2905) https://github.com/python/cpython/commit/9397e2a87ed6e0e724ad71a0c751553620cb7

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: I am going to work on this now. Tracers should be on for the duration of the test class except for the load test. d = self.page is what I planned initially. Argument note is bound to parameter parent and that will remain the name. The one error I see in Page

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Cheryl Sabella added the comment: I'm pushing step 2 with an error in the test. It's on the keydown in test_fontlist_key. I just didn't want to hold you up from looking at the rest of it because of one test. I did run into a bunch of other issues/questions while doing this. I didn't add tr

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: I will push Notebook when CI passes. We can then do Step 2 for class FontPage(Frame). Consider the font code frozen for now. Pass 'note', not the dialog, as the parent. This makes tab switching work better. Create the highlight frame first and pass it as a

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: When replying by email, snip the quote. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Cheryl Sabella added the comment: OK, once 30853 is merged, I'll recopy the font code into the class. On Fri, Jul 28, 2017 at 2:06 AM, Terry J. Reedy wrote: > > Terry J. Reedy added the comment: > > For steps 2 and 3, setUpClass will have to create or retrieve a reverence > to the page class i

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: For steps 2 and 3, setUpClass will have to create or retrieve a reverence to the page class instance. For page functions, 'dialog' will have to be changed to 'self.page'. For hightlight and key pages, I will write the tests using 'self.page', which would sta

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Terry J. Reedy added the comment: I may have changed the Font group since the copy was made. So unless merges since are carefully checked, the configdialog part of Step 1 should be redone. I think the latter would be easier. Since #30853 might be merged tomorrow, I will 'freeze' the font/ind

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Cheryl Sabella added the comment: PR is for step 1 since VarTrace is needed for step 2. -- ___ Python tracker ___ ___ Python-bugs-list

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Changes by Cheryl Sabella : -- pull_requests: +2956 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Changes by Terry J. Reedy : -- nosy: +csabella ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

Changes by Terry J. Reedy : -- dependencies: +IDLE: configdialog -- factor out Tracer subclass ___ Python tracker ___ ___ Python-bugs-

[issue31004] IDLE, configdialog: Factor out FontTab class from ConfigDialog

New submission from Terry J. Reedy: I want to follow the safe way to refactor (from a blog post), rather than the hacker way of refactoring 'in place'. Step 0: Test code to be refactored. Finished in 30993. Step 1: Copy code to be refactored and modify as needed to isolate it from the working