[issue3114] bus error on lib2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: done in r64302. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> ___

[issue3114] bus error on lib2to3

Adam Olsen <[EMAIL PROTECTED]> added the comment: Looking good. ___ Python tracker <[EMAIL PROTECTED]> ___ ___ Python-bugs-list mailing list Unsu

[issue3114] bus error on lib2to3

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch against the current py3k, along with a stricter test (which fails both with the previous patch, and the original unpatched py3k). I've also checked the svnmerged test_lib2to3 doesn't crash. Added file: http://bugs.python.org/f

[issue3114] bus error on lib2to3

Changes by Benjamin Peterson <[EMAIL PROTECTED]>: -- priority: release blocker -> normal ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3114] bus error on lib2to3

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: PS: I don't think this is "release blocker" anymore. ___ Python tracker <[EMAIL PROTECTED]> ___ ___

[issue3114] bus error on lib2to3

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Adam is right, we should use three temporaries so that the tstate is consistent when the former values are DECREf'ed. I'll produce a patch later today, unless someone beats me to it. ___ Python tracker <[EM

[issue3114] bus error on lib2to3

Guido van Rossum <[EMAIL PROTECTED]> added the comment: N.B. Benjamin made a typo in the revision, it's r64284. -- nosy: +gvanrossum resolution: fixed -> status: closed -> open ___ Python tracker <[EMAIL PROTECTED]>

[issue3114] bus error on lib2to3

Adam Olsen <[EMAIL PROTECTED]> added the comment: I'm not sure that fix is 100% right - it fixes safety, but not correctness. Wouldn't it be more correct to move all 3 into temporaries, assign from tstate, then XDECREF the temporaries? Otherwise you're going to expose just the value or tracebac

[issue3114] bus error on lib2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: Thanks very much. Committed in r64384. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> _

[issue3114] bus error on lib2to3

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: And a test. Added file: http://bugs.python.org/file10630/test_3114.patch ___ Python tracker <[EMAIL PROTECTED]> ___ __

[issue3114] bus error on lib2to3

Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The following patch fixes it, which is somehow a bit scary... -- keywords: +patch Added file: http://bugs.python.org/file10629/3114.patch ___ Python tracker <[EMAIL PROTECTED]>

[issue3114] bus error on lib2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I should mention the Bus error happens at test_future_builtins (lib2to3.tests.test_fixers.Test_filter). ___ Python tracker <[EMAIL PROTECTED]> _

[issue3114] bus error on lib2to3

Benjamin Peterson <[EMAIL PROTECTED]> added the comment: I have determined that this was caused by r64121. -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> ___ _

[issue3114] bus error on lib2to3

New submission from Benjamin Peterson <[EMAIL PROTECTED]>: I was just merging 2to3 work (and you'll have to do svnmerge.py merge in Lib/lib2to3 for this to work) into py3k and was running the tests when this rather alarming thing happended: $ ./python.exe Lib/test/regrtest.py test_lib2to3 ... te