[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

STINNER Victor added the comment: commit fae0512e58619231a566bf77aa21148440b0ec8d Author: Miss Islington (bot) <31488909+miss-isling...@users.noreply.github.com> Date: Thu Oct 5 07:10:59 2017 -0700 [3.6] bpo-31178: Mock os.waitpid() in test_subprocess (GH-3896)

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Change by Roundup Robot : -- pull_requests: +3868 stage: resolved -> patch review ___ Python tracker ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

STINNER Victor added the comment: New changeset 11045c9d8a21dd9bd182a3939189db02815f9783 by Victor Stinner in branch 'master': bpo-31178: Mock os.waitpid() in test_subprocess (#3896) https://github.com/python/cpython/commit/11045c9d8a21dd9bd182a3939189db02815f9783

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

STINNER Victor added the comment: > In a REPL on my Fedora 26, os.waitpid(0, 0) raises "ChildProcessError: [Errno > 10] No child processes". I'm not sure that waitpid() is the cause of the > hang, (...) Oh wait, now I understood the full picture. Summary: * 2 new

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

STINNER Victor added the comment: A colleague packaging Python for Red Hat Entreprise Linux reported me that tests hang randomly on test_exception_errpipe_bad_data() of test_subprocess. I don't know why exactly, but using strace, I noticed that the "unit test" calls

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Change by STINNER Victor : -- pull_requests: +3867 ___ Python tracker ___ ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Changes by Gregory P. Smith : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Gregory P. Smith added the comment: New changeset 3bad1650a03fdc8cfdd4cce154e1b2c07e3e4fa0 by Gregory P. Smith in branch '3.6': [3.6] bpo-31178: Avoid concatenating bytes with str in subprocess error (GH-3066) (#3388)

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Changes by Gregory P. Smith : -- pull_requests: +3395 ___ Python tracker ___ ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Ammar Askar added the comment: If it doesn't manage to make it by tomorrow afternoon, I can backport it manually. It doesn't look like its been able to do it yet. -- nosy: +ammar2 ___ Python tracker

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Gregory P. Smith added the comment: awaiting our new carrot nosed bot the create the backport PR to take care of 3.6 :) -- assignee: -> gregory.p.smith versions: +Python 3.6 -Python 3.7 ___ Python tracker

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Gregory P. Smith added the comment: New changeset 3fc499bca18454b9f432b9b0106cab662bfeb549 by Gregory P. Smith (Ammar Askar) in branch 'master': bpo-31178: Avoid concatenating bytes with str in subprocess error (#3066)

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

Changes by Ammar Askar : -- pull_requests: +3103 ___ Python tracker ___ ___

[issue31178] [EASY] subprocess: TypeError: can't concat str to bytes, in _execute_child()

New submission from STINNER Victor: Lib/subprocess.py contains the following code: try: exception_name, hex_errno, err_msg = ( errpipe_data.split(b':', 2)) except ValueError: exception_name =