[issue31455] ElementTree.XMLParser() mishandles exceptions

Change by Serhiy Storchaka : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list ma

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: New changeset c498cd8bf81fc47acf2f1f702e8b3bc9bd4aed65 by Serhiy Storchaka (scoder) in branch '2.7': bpo-31544: Fix a reference leak to 'self' after the previous target error handling fixes. (GH-6318) https://github.com/python/cpython/commit/c498cd8bf81fc47a

[issue31455] ElementTree.XMLParser() mishandles exceptions

Stefan Behnel added the comment: PR 6318 fixes the reference leak for Py2.7. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue31455] ElementTree.XMLParser() mishandles exceptions

Change by Stefan Behnel : -- pull_requests: +6034 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing

[issue31455] ElementTree.XMLParser() mishandles exceptions

Stefan Behnel added the comment: Right, Zachary, thanks for noticing. Py2.7 is actually way more different than I thought, and I hadn't paid enough attention to that. Py3 does all of this in "__init__", whereas Py2 essentially implements "__new__" in C, which requires more cleanup. BTW, the

[issue31455] ElementTree.XMLParser() mishandles exceptions

Zachary Ware added the comment: This added a refleak on 2.7, see http://buildbot.python.org/all/#/builders/78/builds/122 and later builds. Also, the bug ID in the blurb is incorrect (31544 vs 31455). -- nosy: +zach.ware status: closed -> open ___

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: New changeset 0694b6a651ba2a53f6323ffb3b23358f43885815 by Serhiy Storchaka (scoder) in branch '2.7': bpo-31544: Avoid calling "PyObject_GetAttrString()" (and potentially executing user code) with a live exception set. (GH-3992) https://github.com/python/cpyt

[issue31455] ElementTree.XMLParser() mishandles exceptions

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ _

[issue31455] ElementTree.XMLParser() mishandles exceptions

Stefan Behnel added the comment: Backport PR for 2.7 added: 3992 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubsc

[issue31455] ElementTree.XMLParser() mishandles exceptions

Change by Stefan Behnel : -- pull_requests: +3968 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: It would be nice. But I see you already have opened issue31758 for reference leaks. I think that other problems can be solved in the same issue. Do you mind to backport your patch to 2.7 Stefan? If this makes sense. Otherwise I'll just close this issue. Liv

[issue31455] ElementTree.XMLParser() mishandles exceptions

Oren Milman added the comment: Serhiy, in addition to the problems you mentioned with not calling __init__(), it seems that calling every method of an uninitialized XMLParser object would crash. If you don't mind, i would be happy to open an issue to fix these crashes. -- nosy: +Oren

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: New changeset 49caab46f687eb201898fb6c2c40d47bdcb0e58b by Serhiy Storchaka (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (GH-3545) (#3585) https://github.com/python/cpython/commit/49caab46f687eb

[issue31455] ElementTree.XMLParser() mishandles exceptions

Changes by Roundup Robot : -- pull_requests: +3576 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: New changeset c8d8e15bfc24abeeaaf3d8be9073276b0c011cdf by Serhiy Storchaka (scoder) in branch 'master': bpo-31455: Fix an assertion failure in ElementTree.XMLParser(). (#3545) https://github.com/python/cpython/commit/c8d8e15bfc24abeeaaf3d8be9073276b0c011cdf

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: I agree. While these issues are not totally independent (they changes the same code), my issue needs uncommon use of __new__ and __init__, while your issue can be exposed in normal cases. -- ___ Python tracker

[issue31455] ElementTree.XMLParser() mishandles exceptions

Stefan Behnel added the comment: Feel free to provide a separate pull request. These issues seem independent of the exception handling problem that I wrote a fix for. -- ___ Python tracker ___

[issue31455] ElementTree.XMLParser() mishandles exceptions

Serhiy Storchaka added the comment: Oh, I see many other issues with C implementation of ElementTree. 1. If XMLParser.__init__ is called twice, it leaks references and the Expat parser. Possible solution: use the Py_XSETREF() macro instead of simple assignment. The Expat parser needs special

[issue31455] ElementTree.XMLParser() mishandles exceptions

Changes by Serhiy Storchaka : -- nosy: +eli.bendersky, haypo, serhiy.storchaka versions: +Python 2.7, Python 3.6 ___ Python tracker ___ _

[issue31455] ElementTree.XMLParser() mishandles exceptions

Changes by Stefan Behnel : -- keywords: +patch pull_requests: +3542 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue31455] ElementTree.XMLParser() mishandles exceptions

New submission from Stefan Behnel: The "XMLParser.__init__()" method in "_elementtree.c" contains this code: self->handle_start = PyObject_GetAttrString(target, "start"); self->handle_data = PyObject_GetAttrString(target, "data"); self->handle_end = PyObject_GetAttrString(target, "en