[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Oh, I missed this. My report is based on the same comment on news.ycombinator.com. -- ___ Python tracker

[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. Your analysis is correct and this is a duplicate of issue 31325. I'll take care of the PR 3259. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> req_rate is a

[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: For the performance of namedtuple type creation see issue28638 and https://mail.python.org/pipermail/python-dev/2017-July/148592.html. For difference between types and instance see

[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Nikolay Bogoychev
Nikolay Bogoychev added the comment: Hey Serhiy, The use of namedtuple was requested specifically at a review, I didn't implement it like this initially: https://bugs.python.org/review/16099/#ps6205 I wasn't aware of the performance implications. Could you please explain to

[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : There are issues in implementing support of request rate in robotparser. req_rate = collections.namedtuple('req_rate', 'requests seconds') entry.req_rate = req_rate