[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-10 Thread STINNER Victor
STINNER Victor added the comment: > Why not use just abort() or Py_FatalError()? I try to test how a real program crash, like a real invalid memory read. Maybe it doesn't matter much here. -- ___ Python tracker

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-09 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Why not use just abort() or Py_FatalError()? $ ./python -c 'import ctypes; ctypes.CDLL("libc.so.6").abort()' Aborted (core dumped) $ ./python -c 'import ctypes; ctypes.pythonapi.Py_FatalError(b"boom!")' Fatal Python error: boom! Current thread 0x7f26805

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-09 Thread STINNER Victor
STINNER Victor added the comment: The main issue with reading from NULL is that it may not crash on AIX. But I checked: test_regrtest passed on our AIX buildbot. -- ___ Python tracker __

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-09 Thread STINNER Victor
STINNER Victor added the comment: For the records, test_regrtest.test_crashed() uses faulthandler._sigsegv() in the master branch. This function calls raise(SIGSEGV) directly, rather than trying to read from NULL (address 0). -- resolution: -> fixed stage: patch review -> resolved st

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-09 Thread STINNER Victor
STINNER Victor added the comment: New changeset cc4b6f1c6210460c0645b1df508e114e16805784 by Victor Stinner in branch '2.7': bpo-31719: Fix test_regrtest.test_crashed() on s390x (#3912) https://github.com/python/cpython/commit/cc4b6f1c6210460c0645b1df508e114e16805784 -- _

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-09 Thread Iryna Shcherbina
Iryna Shcherbina added the comment: I have run a build with the patch applied, and can confirm that the tests pass on s390x. Full build log can be viewed here: https://kojipkgs.fedoraproject.org//work/tasks/9473/22339473/build.log -- ___ Python tr

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-06 Thread STINNER Victor
Change by STINNER Victor : -- nosy: +cstratak, ishcherb ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-06 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +3885 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-li

[issue31719] [2.7] test_regrtest.test_crashed() fails on s390x

2017-10-06 Thread STINNER Victor
New submission from STINNER Victor : On the s390x architecture, the test_regrtest.test_crashed() fails because Python doesn't crash. test.support._crash_python() calls ctypes.string_at(0) to crash Python. In debug mode, ctypes.string_at(0) fails with an assertion error and the process is kill