[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Karthikeyan Singaravelan added the comment: PR was merged and backported to 3.7. So I am closing this as fixed. Thanks Rémi for the patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Chris Withers added the comment: New changeset a6516f89aa0f416c7514ac364bb48ac7d1455487 by Chris Withers (Miss Islington (bot)) in branch '3.7': bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (GH-11521) (#13152)

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Change by miss-islington : -- pull_requests: +13068 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Chris Withers added the comment: New changeset 11a8832c98b3db78727312154dd1d3ba76d639ec by Chris Withers (Rémi Lapeyre) in branch 'master': bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (GH-11521)

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Change by Rémi Lapeyre : -- keywords: +patch, patch, patch pull_requests: +11098, 11099, 11100 stage: -> patch review ___ Python tracker ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Change by Rémi Lapeyre : -- keywords: +patch, patch pull_requests: +11098, 11099 stage: -> patch review ___ Python tracker ___ ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Change by Rémi Lapeyre : -- keywords: +patch pull_requests: +11098 stage: -> patch review ___ Python tracker ___ ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Rémi Lapeyre added the comment: The off-by-one error in a test added for an unrelated issue (#17467) makes me think @michael.foord just made a mistake in the test. > mock_open docs mentions about using a customized mock for complex cases I think it's more for complex things like fetching data

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Karthikeyan Singaravelan added the comment: Internally mock_open implementation uses line based iteration [0] to keep track of the state change between read calls. So readline too ignores the argument. There is issue25690 for an alternate mock_open implementation but the code change is

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Change by Raymond Hettinger : -- assignee: -> michael.foord nosy: +michael.foord ___ Python tracker ___

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

Ron Rothman added the comment: Confirmed that the behavior exists in Python 3.6 as well. -- versions: +Python 3.6 ___ Python tracker

[issue31855] mock_open is not compatible with read(n) (and pickle.load)

New submission from Ron Rothman : mock.mock_open works as expected when reading the entire file (read()) or when reading a single line (readline()), but it seems to not support reading a number of bytes (read(n)). These work as expected: from mock import mock_open,