[issue31938] Convert selectmodule.c to Argument Clinic

STINNER Victor added the comment: Thanks Anthony Sottile for fixing pydoc select! The fix is now in 3.8, 3.9 and master branches. -- ___ Python tracker ___ __

[issue31938] Convert selectmodule.c to Argument Clinic

STINNER Victor added the comment: pydoc doesn't show the eventmask parameter whereas it is in select.epoll.register.__text_signature__. I created bpo-41095: "inspect.signature() doesn't parse __text_signature__ containing a newline character". -- ___

[issue31938] Convert selectmodule.c to Argument Clinic

STINNER Victor added the comment: > There is no need to change default-value signatures. The root problem is that > select.epoll.register does not have the __module__ attribute. Oh, I saw your comment after merging Anthony's PR. At least, I confirm that it fix the reported issue: "./python -

[issue31938] Convert selectmodule.c to Argument Clinic

miss-islington added the comment: New changeset 48fc35ada7c4237f11bb9638387bfe5b4cebfb12 by Anthony Sottile in branch '3.9': [3.9] bpo-31938: Fix default-value signatures of several functions in the select module (GH-21066) (GH-21097) https://github.com/python/cpython/commit/48fc35ada7c4237f

[issue31938] Convert selectmodule.c to Argument Clinic

miss-islington added the comment: New changeset 60cbdc81d1bd5c175ff890ee4cfdc85c10090b75 by Anthony Sottile in branch '3.8': [3.8] bpo-31938: Fix default-value signatures of several functions in the select module (GH-21066) (GH-21098) https://github.com/python/cpython/commit/60cbdc81d1bd5c17

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Anthony Sottile : -- pull_requests: +20265, 20266 pull_request: https://github.com/python/cpython/pull/21098 ___ Python tracker ___ __

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Anthony Sottile : -- pull_requests: +20265 pull_request: https://github.com/python/cpython/pull/21098 ___ Python tracker ___ _

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Anthony Sottile : -- pull_requests: +20265, 20266, 20267 pull_request: https://github.com/python/cpython/pull/21098 ___ Python tracker ___ ___

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Anthony Sottile : -- pull_requests: +20264 pull_request: https://github.com/python/cpython/pull/21097 ___ Python tracker ___ _

[issue31938] Convert selectmodule.c to Argument Clinic

STINNER Victor added the comment: New changeset d051801052211b533c46a593b1c1bccf649a171c by Anthony Sottile in branch 'master': bpo-31938: Fix default-value signatures of several functions in the select module (GH-21066) https://github.com/python/cpython/commit/d051801052211b533c46a593b1c1bc

[issue31938] Convert selectmodule.c to Argument Clinic

Serhiy Storchaka added the comment: There is no need to change default-value signatures. The root problem is that select.epoll.register does not have the __module__ attribute. Well, seems that all method objects do not have the __module__ attribute. There are two solutions: 1. Make inspect

[issue31938] Convert selectmodule.c to Argument Clinic

Change by STINNER Victor : -- pull_requests: +20236 pull_request: https://github.com/python/cpython/pull/21067 ___ Python tracker ___ __

[issue31938] Convert selectmodule.c to Argument Clinic

Anthony Sottile added the comment: This appears to have broken pydoc of the select module, I've attached a patch $ python3.8 -m pydoc select Traceback (most recent call last): File "/usr/lib/python3.8/inspect.py", line 2004, in wrap_value value = eval(s, module_dict) File "", line 1, i

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Anthony Sottile : -- nosy: +Anthony Sottile nosy_count: 4.0 -> 5.0 pull_requests: +20235 pull_request: https://github.com/python/cpython/pull/21066 ___ Python tracker ___

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: New changeset 0e6e7a1e52a53090e33ebef13f8f1fbe9bec2375 by Tal Einat (Michael Osipov) in branch 'master': bpo-34419: selectmodule.c does not compile on HP-UX due to bpo-31938 (GH-8796) https://github.com/python/cpython/commit/0e6e7a1e52a53090e33ebef13f8f1fbe9bec237

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Michael Osipov <1983-01...@gmx.net>: -- pull_requests: +8272 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- versions: +Python 3.8 -Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: ht

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: -7636 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- Removed message: https://bugs.python.org/msg320777 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: -7637 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- Removed message: https://bugs.python.org/msg320779 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: New changeset 6dc57e2a20c5beb99e8bf5eb04cc836d53fa9aee by Tal Einat in branch 'master': bpo-31938: Convert selectmodule.c to Argument Clinic (GH-4265) https://github.com/python/cpython/commit/6dc57e2a20c5beb99e8bf5eb04cc836d53fa9aee -- _

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: New changeset db7ac30ef52ce35a4ead1bc1b9f0dd5331ed9779 by Tal Einat in branch '3.6': [3.6] bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8025) https://github.com/python/cpython/commit/db7ac30ef52ce35a4ead1bc1b9f0dd5331ed9779 -- __

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: New changeset fd1c092bb9fee46d8d543710973c69a0e93a697a by Tal Einat (Miss Islington (bot)) in branch '3.7': bpo-32568: make select.epoll() and its docs consistent (GH-7840) (GH-8024) https://github.com/python/cpython/commit/fd1c092bb9fee46d8d543710973c69a0e93a697a

[issue31938] Convert selectmodule.c to Argument Clinic

Change by miss-islington : -- pull_requests: +7637 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: +7636 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- Removed message: https://bugs.python.org/msg320775 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: -7634 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: -7450 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.p

[issue31938] Convert selectmodule.c to Argument Clinic

Change by miss-islington : -- pull_requests: +7634 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: New changeset 0cdf5f42898350261c5ff65d96334e736130780f by Tal Einat in branch 'master': bpo-32568: make select.epoll() and its docs consistent (#7840) https://github.com/python/cpython/commit/0cdf5f42898350261c5ff65d96334e736130780f -- _

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: When ready, should this (and other AC conversions) be backported to the relevant 3.x branches? -- ___ Python tracker ___

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- pull_requests: +7450 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue31938] Convert selectmodule.c to Argument Clinic

STINNER Victor added the comment: While reviewing PR 4265, I noticed that the return type like "-> None" or "-> int" is removed from the function definition, so the PR removes this information. But it seems to be a limitation of Argument Clinic: I opened the issue #31939. IHMO it's not a blo

[issue31938] Convert selectmodule.c to Argument Clinic

Change by Tal Einat : -- keywords: +patch pull_requests: +4228 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list ma

[issue31938] Convert selectmodule.c to Argument Clinic

Tal Einat added the comment: See PR 4265. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyt

[issue31938] Convert selectmodule.c to Argument Clinic

New submission from Tal Einat : Continuing the work begun as part of issue #20182, this is regarding the Argument Clinic conversion of Modules/selectmodule.c.h. I have a complete conversion ready and will create a PR momentarily. -- components: Argument Clinic messages: 305514 nosy: ha