[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Antoine Pitrou added the comment: Thank you for posting this Benjamin. As I said on the PR, I don't think I want to backport this to 3.6, as it is always delicate to reason about subclassing and threads. -- versions: -Python 3.6

[issue31976] Segfault when closing BufferedWriter from a different thread

Antoine Pitrou added the comment: New changeset 9703f092abc0259926d88c7855afeae4a78afc7d by Antoine Pitrou (benfogle) in branch 'master': bpo-31976: Fix race condition when flushing a file is slow. (#4331)

[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Antoine Pitrou : -- nosy: +martin.panter ___ Python tracker ___ ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Antoine Pitrou : -- nosy: +benjamin.peterson, stutzbach ___ Python tracker ___ ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Benjamin Fogle : -- type: -> crash ___ Python tracker ___ ___

[issue31976] Segfault when closing BufferedWriter from a different thread

Change by Benjamin Fogle : -- keywords: +patch pull_requests: +4287 stage: -> patch review ___ Python tracker ___

[issue31976] Segfault when closing BufferedWriter from a different thread

New submission from Benjamin Fogle : To reproduce: ``` import threading import io import time import _pyio class MyFileIO(io.FileIO): def flush(self): # Simulate a slow flush. Slow disk, etc. time.sleep(0.25) super().flush() raw =