[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: I think this issue is resolved, right? Closing. Please reopen if there's anything left to do. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue32107] Improve MAC address calculation and fix test_uuid.py

Serhiy Storchaka added the comment: New changeset e69fbb6a560a02d0587b9075afd338a1e9073af0 by Serhiy Storchaka in branch 'master': Fix a regression in uuid added in bpo-32107. (#4677)

[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: I missed it too. Serhiy, do you want to add that fix to your already open PR 4677? -- ___ Python tracker

[issue32107] Improve MAC address calculation and fix test_uuid.py

Xavier de Gaye added the comment: When I am the author of a regression (as I have been too many times unfortunately), I prefer to be the one that reverts the changes and I would not like someone else to do it. -- ___ Python

[issue32107] Improve MAC address calculation and fix test_uuid.py

Serhiy Storchaka added the comment: Ah, good catch! I missed this. Do you mind to create a PR Xavier? -- ___ Python tracker

[issue32107] Improve MAC address calculation and fix test_uuid.py

Xavier de Gaye added the comment: 1. Before the regression made by 23df2d1304ece169d7e0dfc843dfb8026b413d9f, on the first invocation of getnode(), the returned value is cached in '_node' (a global variable) and getnode() is idempotent. 2. After

[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: > Sorry, but I can't understand how 23df2d1304ece169d7e0dfc843dfb8026b413d9f > could break getnode() on Android and how your changes can fix this. The only > effect of this change is that an error in _random_getnode() no longer > silenced.

[issue32107] Improve MAC address calculation and fix test_uuid.py

Serhiy Storchaka added the comment: Sorry, but I can't understand how 23df2d1304ece169d7e0dfc843dfb8026b413d9f could break getnode() on Android and how your changes can fix this. The only effect of this change is that an error in _random_getnode() no longer

[issue32107] Improve MAC address calculation and fix test_uuid.py

Xavier de Gaye added the comment: > I don't know how the proposed change can help. It helps by fixing the regression introduced by a change made in 23df2d1304ece169d7e0dfc843dfb8026b413d9f in this issue, a change that has been made only in the master branch. Before that

[issue32107] Improve MAC address calculation and fix test_uuid.py

Serhiy Storchaka added the comment: I don't know how the proposed change can help. PR 4677 makes the test more lenient. -- stage: patch review -> needs patch ___ Python tracker

[issue32107] Improve MAC address calculation and fix test_uuid.py

Change by Serhiy Storchaka : -- pull_requests: +4585 stage: needs patch -> patch review ___ Python tracker ___

[issue32107] Improve MAC address calculation and fix test_uuid.py

Xavier de Gaye added the comment: test_uuid fails now on android-24-armv7 on the master branch: == FAIL: test_getnode (test.test_uuid.TestUUIDWithoutExtModule)

[issue32107] Improve MAC address calculation and fix test_uuid.py

Change by Barry A. Warsaw : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: New changeset 23cc8c0f9ece32f1f96133b9db2cb30c64f23a0e by Barry Warsaw in branch '3.6': [3.6] bpo-32107 - Backport bitmask check fix (GH-4576) (#4591) https://github.com/python/cpython/commit/23cc8c0f9ece32f1f96133b9db2cb30c64f23a0e

[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: New changeset 56e444f8df34cd502d6e3b110c90aed086883a72 by Barry Warsaw in branch '2.7': [2.7] bpo-32107 - Backport bitmask check fix (GH-4576) (#4590) https://github.com/python/cpython/commit/56e444f8df34cd502d6e3b110c90aed086883a72

[issue32107] Improve MAC address calculation and fix test_uuid.py

Barry A. Warsaw added the comment: New changeset 23df2d1304ece169d7e0dfc843dfb8026b413d9f by Barry Warsaw in branch 'master': bpo-32107 - Improve MAC address calculation and fix test_uuid.py (#4600)

[issue32107] Improve MAC address calculation and fix test_uuid.py

Change by Barry A. Warsaw : -- title: test_uuid uses the incorrect bitmask -> Improve MAC address calculation and fix test_uuid.py ___ Python tracker