[issue32136] Move embedding tests to their own test module

2017-11-27 Thread Nick Coghlan
Change by Nick Coghlan : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32136] Move embedding tests to their own test module

2017-11-27 Thread Nick Coghlan
Nick Coghlan added the comment: New changeset 39f0bb5ad0715dbfc0a2d5dd6d0ddea9e4c65ae2 by Nick Coghlan in branch 'master': bpo-32136: Separate embedding tests from C API tests (GH-4567) https://github.com/python/cpython/commit/39f0bb5ad0715dbfc0a2d5dd6d0ddea9e4c65ae2

[issue32136] Move embedding tests to their own test module

2017-11-27 Thread STINNER Victor
STINNER Victor added the comment: > Modules/_testcapi.c -> Lib/test/test_capi.py > Progams/_testembed.c -> Lib/test/test_embed.py I like it :-) -- ___ Python tracker

[issue32136] Move embedding tests to their own test module

2017-11-26 Thread Nick Coghlan
Nick Coghlan added the comment: I guess the shorted name would also better match the naming scheme used for the C API test module: Modules/_testcapi.c -> Lib/test/test_capi.py Progams/_testembed.c -> Lib/test/test_embed.py --

[issue32136] Move embedding tests to their own test module

2017-11-26 Thread STINNER Victor
STINNER Victor added the comment: What about a shorter name like test_embed? -- ___ Python tracker ___

[issue32136] Move embedding tests to their own test module

2017-11-25 Thread Nick Coghlan
Change by Nick Coghlan : -- keywords: +patch pull_requests: +4495 stage: needs patch -> patch review ___ Python tracker ___

[issue32136] Move embedding tests to their own test module

2017-11-25 Thread Nick Coghlan
Nick Coghlan added the comment: As noted in https://bugs.python.org/issue32096#msg306989, it would also be good to ensure that the full traceback from a failed `_testembed` call is always visible when running in verbose mode. --

[issue32136] Move embedding tests to their own test module

2017-11-25 Thread Nick Coghlan
New submission from Nick Coghlan : We currently run the runtime embedding tests as a subsection of "test_capi". I'm thinking it may make more sense to clearly separate them out as their own CPython-only test file, "test_runtime_embedding". I'm also thinking we should add a