Changes by Benjamin Peterson [EMAIL PROTECTED]:
--
resolution: - accepted
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3218
___
Benjamin Peterson [EMAIL PROTECTED] added the comment:
I've fixed the tests, so you can cross that one off your list. However,
the buildbots are now failing because lib2to3 takes too long to test.
How soon can we have this optimization applied?
--
nosy: +benjamin.peterson
Nick Edds [EMAIL PROTECTED] added the comment:
I can hopefully have it all fixed up by tonight or tomorrow.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3218
___
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Can we expect this in the next 2 hours? It's fine if not, I just need to
know whether the 2to3 tests should be disabled for the beta.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3218
Nick Edds [EMAIL PROTECTED] added the comment:
It should be done tonight, but probably not until around 11 central
time. Sorry for the delay.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3218
___
Nick Edds [EMAIL PROTECTED] added the comment:
Sorry I couldn't have this done earlier today. I updated the test suite,
and this is now passing all tests. Collin, could you verify that is has
all the functionality you were expecting? If the member functionality
turns out to actually be important
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Thanks very much for getting this done! I checked in the changes in
r65053, so they can make beta 2. I'm leaving the issue open, though, in
case Collin wants to make more changes.
___
Python tracker
Nick Edds [EMAIL PROTECTED] added the comment:
Yeah that import_as_names definitely shouldn't be there. I don't know
what I was thinking at the time, but that should just be an any I
believe. I'll clean this up today or tomorrow, update fix_imports2 as
well, and try to fix the tests for
Changes by Benjamin Peterson [EMAIL PROTECTED]:
--
priority: - high
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3218
___
___
Python-bugs-list
Collin Winter [EMAIL PROTECTED] added the comment:
fix_imports.diff fails to apply cleanly against HEAD of fix_imports.py.
Also, fix_imports2 now inherits from fix_imports, so it needs to be
fixed as well.
+ yield power module_name=%r
+ trailer'.' import_as_names any
Collin Winter [EMAIL PROTECTED] added the comment:
The change to pytree.py doesn't add much speed benefit over the
fix_imports.py change, and causes a test to fail.
The fix_imports.py change, on the other hand, takes the test suite run
time from 8m31s down to 1m45s -- this needs to go in!
That
Nick Edds [EMAIL PROTECTED] added the comment:
Here is a diff for the both the fix_imports changes which I corrected,
and the pytree changes. The pytree changes were a lot more significant
before the fix_imports change, but I think they are still a decent
improvement. I think I have now restored
New submission from Nick Edds [EMAIL PROTECTED]:
This is an optimization in pytree.py specifically for the bare_name
pattern from fix_imports.py. It also has the isinstance change I
previously suggested piggybacked onto it. Because the bare_name pattern
is so massive (764 nodes!), it is very
13 matches
Mail list logo
