[issue32460] don't use tentative declarations

2017-12-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: New changeset 0a37a30037073a4a9ba45e560c8445048e5f2ba2 by Benjamin Peterson in branch 'master': closes bpo-32460: ensure all non-static globals have initializers (#5061) https://github.com/python/cpython/commit/0a37a30037073a4a9ba45e560c8445048e5f2ba2 ---

[issue32460] don't use tentative declarations

2017-12-31 Thread Benjamin Peterson
Benjamin Peterson added the comment: If no definition provides an initializer, they'll end up initialized to 0. The legacy part is that you can have multiple tentative definitions of a symbol and most unix linkers will merge them. -- ___ Python tra

[issue32460] don't use tentative declarations

2017-12-31 Thread Antoine Pitrou
Antoine Pitrou added the comment: Sounds like good hygiene to me, though I didn't know that "tentative declarations" were legacy (don't they simply mean the variable gets an arbitrary initialization value?). -- nosy: +pitrou ___ Python tracker

[issue32460] don't use tentative declarations

2017-12-30 Thread Benjamin Peterson
Change by Benjamin Peterson : -- keywords: +patch pull_requests: +4937 stage: -> patch review ___ Python tracker ___ ___ Python-bugs

[issue32460] don't use tentative declarations

2017-12-30 Thread Benjamin Peterson
New submission from Benjamin Peterson : Tentative declarations (non-extern declarations without initializers) are legacy C-ism that we should eschew by ensuring all our declarations have initializers. -- components: Build messages: 309269 nosy: benjamin.peterson priority: normal severi