[issue32503] Avoid creating small frames in pickle protocol 4

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32503] Avoid creating small frames in pickle protocol 4

Serhiy Storchaka added the comment: New changeset 1211c9a9897a174b7261ca258cabf289815a40d8 by Serhiy Storchaka in branch 'master': bpo-32503: Avoid creating too small frames in pickles. (#5127)

[issue32503] Avoid creating small frames in pickle protocol 4

Serhiy Storchaka added the comment: In the current form the change is trivial, just an additional check. Actually it fixes a regression introduced in issue31993. Currently even empty frames can be produced (when fast=True). --

[issue32503] Avoid creating small frames in pickle protocol 4

Antoine Pitrou added the comment: I don't think the overall gain is meaningful. I'd rather not add too many special cases in the framing code. -- ___ Python tracker

[issue32503] Avoid creating small frames in pickle protocol 4

Serhiy Storchaka added the comment: PR 5127 makes frames be created only when the size of the payload is not less than 4. Since the minimal size of 3 chunks is 3 bytes this is the absolute minimum of frame size. It would be better to count the number of chunks

[issue32503] Avoid creating small frames in pickle protocol 4

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +4988 stage: -> patch review ___ Python tracker ___

[issue32503] Avoid creating small frames in pickle protocol 4

New submission from Serhiy Storchaka : Pickle protocol 4 uses framing for reducing the overhead of calling the read() method for small chunks of data. Most read chunks are small -- opcodes, small integers, short strings, etc, and calling read() for every 1 or 4