[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Geoffrey Thomas added the comment: Opened #44751 and https://github.com/python/cpython/pull/27394 . -- ___ Python tracker ___ ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Arfrever Frehtes Taifersar Arahesis added the comment: Geoffrey Thomas: I agree that including crypt.h only where required is better. Can you file new bug with patch? Benjamin Peterson: I suspect that with crypt.h not included in _cryptmodule.c, crypt() was treated by compiler as implicitly

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Geoffrey Thomas added the comment: Sorry to bump an old thread, but - does need to be in the public Python.h header? Or would it be enough to be in _cryptmodule.c, which is the code that uses crypt_r()? I can provide a quick patch to change that if that seems sound. -- nosy:

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Charalampos Stratakis : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

STINNER Victor added the comment: New changeset 8e230e1eb3d38ad557b5dc5c31166afa35c01ff3 by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) (#5296)

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

STINNER Victor added the comment: New changeset 6ccdad7b1f6fb316e4e85aa1eba8fbdc3169741e by Victor Stinner (Miss Islington (bot)) in branch '2.7': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284) (#5295)

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Christian Heimes added the comment: yes, go ahead -- ___ Python tracker ___ ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

STINNER Victor added the comment: Charalampos, Christian: are you ok to backport the fix to Python 2.7 and 3.6? (PR 5295 and PR 5296) -- nosy: +christian.heimes ___ Python tracker

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Roundup Robot : -- pull_requests: +5143 ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Roundup Robot : -- pull_requests: +5142 ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by STINNER Victor : -- versions: +Python 2.7 -Python 3.8 ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Benjamin Peterson added the comment: Incidentally, why did this manifest as a segfault rather than a compilation error? -- nosy: +benjamin.peterson ___ Python tracker

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

STINNER Victor added the comment: New changeset e768c86ef442ef89004089a8a34ce5909ffb90f2 by Victor Stinner (stratakis) in branch 'master': bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (#5284)

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Charalampos Stratakis : -- pull_requests: +5130 stage: -> patch review ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Charalampos Stratakis : -- components: +Extension Modules ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

Change by Charalampos Stratakis : -- versions: +Python 3.6, Python 3.7, Python 3.8 ___ Python tracker ___

[issue32635] test_crypt segfaults when using libxcrypt instead of libcrypt

New submission from Charalampos Stratakis : Currently in Fedora glibc stopped providing libcrypt[0] a change which is slowly being upstreamed as well[1] in favor of the libxcrypt project[2]. This causes a segfault when importing the crypt module as python assumes that