[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: Ok, let's keep this permanent temporary fix (test skipped until someone finds a solution). I close the issue. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: > Christian: It seems like the test now pass on my Fedora 27. Is it time to > enable the test again? Ignore my comment. I forgot that it's a race condition and I'm still able to get the failure using msg311097 scenario. --

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: Christian: It seems like the test now pass on my Fedora 27. Is it time to enable the test again? -- ___ Python tracker ___

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: Oh. I forgot about this change. The test is still skipped :-( -- ___ Python tracker ___

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Ned Deily added the comment: Since this is just an intermittent test failure and we have lived with it this long, I think it can wait for 3.7.1 at this point. Downgrading to "critical". -- priority: deferred blocker -> critical

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: Christian Heimes: "Ned, I'm going to rewrite part of the test infrastructure during beta phase. (...)" Any progress on rewriting these tests? -- ___ Python tracker

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Change by Fred L. Drake, Jr. : -- nosy: +fdrake ___ Python tracker ___ ___

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Ned Deily added the comment: Let's get the changes into master first and stabilized there and then we can discuss the possibility of a 3.7 backport. -- ___ Python tracker

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Christian Heimes added the comment: Ned, I'm going to rewrite part of the test infrastructure during beta phase. The ssl module now works according to specifications. When the client doesn't recognize a hostname, it aborts the TLS connection with a TLS ALERT message. The

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Barry A. Warsaw added the comment: Yep, I'm seeing those same failures in our internal build of 3.7.0b1. I'll just disable the tests for now and nosy on this issue. -- nosy: +barry ___ Python tracker

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Christian Heimes added the comment: poplib is also affected, see #32753 -- priority: normal -> high stage: patch review -> needs patch type: -> behavior versions: +Python 3.8 ___ Python tracker

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Christian Heimes added the comment: Some tests still use asyncore to test TLS. Yes, that's old asyncore, not asyncio. I suggest that we replace asyncore with a threaded test server from test_ssl. -- nosy: +giampaolo.rodola ___

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: New changeset 51500f37453bbcbc5f1dbc3c38d079c3c1efe5de by Victor Stinner in branch 'master': bpo-32706: Skip test_ftplib.test_check_hostname() (#5422) https://github.com/python/cpython/commit/51500f37453bbcbc5f1dbc3c38d079c3c1efe5de

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

Change by STINNER Victor : -- keywords: +patch pull_requests: +5257 stage: -> patch review ___ Python tracker ___

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

STINNER Victor added the comment: I'm able to reproduce the failure on my Fedora 27 using two terminals: (1) Run the test in a loop: vstinner@apu$ ./python -m test -v test_ftplib -m test_check_hostname -F (2) Stress the system, example: vstinner@apu$ ./python -m test

[issue32706] test_check_hostname() of test_ftplib started to fail randomly

New submission from STINNER Victor : It may be a regression caused by this recent change: --- commit 61d478c71c5341cdc54e6bfb4ace4252852fd972 Author: Christian Heimes Date: Sat Jan 27 15:51:38 2018 +0100 bpo-31399: Let OpenSSL verify