[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: Ok, _overlapped.Overlapped should now have a few less memory leaks :-) -- ___ Python tracker ___

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

miss-islington added the comment: New changeset 059997d78ed1a1a5a364b1846ac972c98c704927 by Miss Islington (bot) in branch '3.7': bpo-32710: Fix _overlapped.Overlapped memory leaks (GH-11489) https://github.com/python/cpython/commit/059997d78ed1a1a5a364b1846ac972c98c704927 --

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +11092, 11093, 11094 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +11092, 11093 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +11092 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: New changeset 5485085b324a45307c1ff4ec7d85b5998d7d5e0d by Victor Stinner in branch 'master': bpo-32710: Fix _overlapped.Overlapped memory leaks (GH-11489) https://github.com/python/cpython/commit/5485085b324a45307c1ff4ec7d85b5998d7d5e0d --

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +11004 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +11004, 11005 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +11004, 11005, 11006 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

miss-islington added the comment: New changeset 88ad48bc98980a40591cc5521703dbb0ad3a9b17 by Miss Islington (bot) in branch '3.7': bpo-32710: Fix leak in Overlapped_WSASend() (GH-11469) https://github.com/python/cpython/commit/88ad48bc98980a40591cc5521703dbb0ad3a9b17 -- nosy:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: I ran test_asyncio refleak hunting on Windows, and there is no more leak! vstinner@WIN C:\vstinner\python\master>python -m test test_asyncio -R 3:3 (...) Total duration: 13 min 24 sec Tests result: SUCCESS I will close this PR once the 3.7 backport is

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +10965, 10966, 10967 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: New changeset a234e148394c2c7419372ab65b773d53a57f3625 by Victor Stinner in branch 'master': bpo-32710: Fix leak in Overlapped_WSASend() (GH-11469) https://github.com/python/cpython/commit/a234e148394c2c7419372ab65b773d53a57f3625 --

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +10965, 10966 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by miss-islington : -- pull_requests: +10965 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: It took me 1 year, a few sleepless nights, multiple attempts to understand the leak, but I eventually found it! WSASend() doesn't release the memory if it fails immediately. I wrote PR 11469 to fix the memory leak. ReadFile() has the same bug, I also fixed

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +10962, 10963, 10964 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +10962, 10963 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- pull_requests: +10962 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: Attached test_aiosend.py is a simplified version of test to trigger the reference leak. Copy it to Lib/test/ and run: vstinner@WIN C:\vstinner\python\master>python -m test test_aiosend -R 3:3 Running Debug|x64 interpreter... Run tests sequentially 0:00:00

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: Interesting commit. No idea if it's related. commit 79790bc35fe722a49977b52647f9b5fe1deda2b7 Author: Victor Stinner Date: Fri Jun 8 00:25:52 2018 +0200 bpo-33694: Fix race condition in asyncio proactor (GH-7498) The cancellation of an

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

STINNER Victor added the comment: Update: * test.test_asyncio.test_sendfile.ProactorEventLoopTests.test_sendfile_close_peer_in_the_middle_of_receiving leaks 1 reference per run: this bug is caused by bpo-35682 and fixed by PR 11462 *

[issue32710] test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows

Change by STINNER Victor : -- title: test_asyncio: ProactorEventLoopTests.test_sendfile_close_peer_in_middle_of_receiving() leaked [4, 4, 3] memory blocks on AMD64 Windows8.1 Refleaks 3.x -> test_asyncio: ProactorEventLoopTests sendfile tests leak references on Windows