[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2021-06-30 Thread Samuel Henrique
Samuel Henrique added the comment: Hello Vinay Sajip, I would like to kindly ask you to please reconsider and give your thoughts on my description of the issue here. Let me try to work based on your last reply: > ...has been around since Jan 2008, and it seems that no one in that time has >

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-06-29 Thread Steffen Schuldenzucker
Steffen Schuldenzucker added the comment: To give you a data point, I just hit this problem. Based on the docs and common sense, I didn't expect LoggerAdapter to throw away the other extra arguments. I strongly feel that this is a bug. I cannot see how it could be desired behavior over the

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-03-02 Thread Vinay Sajip
Vinay Sajip added the comment: The existing LoggerAdapter functionality has been around since Jan 2008, and it seems that no one in that time has raised this as a must-have. In summary: 1. If you want to pass different kwargs in every time, use a logger. 2. If you

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-03-01 Thread Cyril Martin
Cyril Martin added the comment: Hello Vinay, I strongly disagree with you. In the Python documentation (https://docs.python.org/3/library/logging.html), we can read the following for the debug function: > The third keyword argument is extra which can be used to pass a

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-02-28 Thread Vinay Sajip
Vinay Sajip added the comment: This is not a bug, so I have closed the PR and am closing the issue. You might expect extras to be merged, but you can either pass extras in the constructor (as you have observed) or by subclassing LoggerAdapter and overriding the

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-02-28 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +vinay.sajip ___ Python tracker ___ ___

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-02-28 Thread Cyril Martin
Cyril Martin added the comment: Hi Stéphane, I ask you a question about the change you suggest. The PR has not progress. Do you wait something from me? -- ___ Python tracker

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-02-01 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Hi Cyril, I have commented your PR -- nosy: +matrixise ___ Python tracker ___

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-01-31 Thread Cyril Martin
New submission from Cyril Martin : - LoggerAdapter processes only extra kwargs given during its __init__ So extra kwargs, given to Logger#log are ignored when we configure a LoggerAdapter (same for: debug, info, warning etc). - I expect extras are merged. More precisely, I