[issue32841] Asyncio.Condition prevents cancellation

Bar Harel added the comment: Yup. Thanks Yuri :-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue32841] Asyncio.Condition prevents cancellation

Yury Selivanov added the comment: Should this issue be closed now? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsub

[issue32841] Asyncio.Condition prevents cancellation

Andrew Svetlov added the comment: Well, makes sense -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:

[issue32841] Asyncio.Condition prevents cancellation

Nathaniel Smith added the comment: > Having shield not cancel immediately but rather wait and cancel will cause > long timed shielded operations to stall the task cancellation, usually for no > good. This isn't the general case. What I'm suggesting is that maybe it actually is good in the gen

[issue32841] Asyncio.Condition prevents cancellation

Andrew Svetlov added the comment: Thanks Bar Harel -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue32841] Asyncio.Condition prevents cancellation

Andrew Svetlov added the comment: New changeset a23eecab9a0b724bdfde83d159ac2415927f042a by Andrew Svetlov (Miss Islington (bot)) in branch '3.6': bpo-32841: Fix cancellation in awaiting asyncio.Condition (GH-5665) (GH-5683) https://github.com/python/cpython/commit/a23eecab9a0b724bdfde83d159ac

[issue32841] Asyncio.Condition prevents cancellation

miss-islington added the comment: New changeset 8caee0fa572e8ced00df553a7bdca49ddaf729e8 by Miss Islington (bot) in branch '3.7': bpo-32841: Fix cancellation in awaiting asyncio.Condition (GH-5665) https://github.com/python/cpython/commit/8caee0fa572e8ced00df553a7bdca49ddaf729e8 -- n

[issue32841] Asyncio.Condition prevents cancellation

Change by miss-islington : -- pull_requests: +5478 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32841] Asyncio.Condition prevents cancellation

Change by miss-islington : -- pull_requests: +5477 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue32841] Asyncio.Condition prevents cancellation

Andrew Svetlov added the comment: New changeset 5746510b7aef423fa4afc92b2abb919307b1dbb9 by Andrew Svetlov (Bar Harel) in branch 'master': bpo-32841: Fix cancellation in awaiting asyncio.Condition (#5665) https://github.com/python/cpython/commit/5746510b7aef423fa4afc92b2abb919307b1dbb9 -

[issue32841] Asyncio.Condition prevents cancellation

Bar Harel added the comment: I don't think so. Having shield not cancel immediately but rather wait and cancel will cause long timed shielded operations to stall the task cancellation, usually for no good. This isn't the general case. However, adding another function which does so might just be

[issue32841] Asyncio.Condition prevents cancellation

Nathaniel Smith added the comment: It does make me wonder if asyncio.shield *should* wait for the thing it's shielding though, so that it *would* work in this case? (Similar to bpo-32751.) -- ___ Python tracker

[issue32841] Asyncio.Condition prevents cancellation

Nathaniel Smith added the comment: Interesting case! This is super subtle. I think the patch is correct though. (In Trio this is one of the cases where we use shielding: https://github.com/python-trio/trio/blob/f48d8922dfe2118bfaaf9a85f2524e58146ba369/trio/_sync.py#L749-L752 . But asyncio.shi

[issue32841] Asyncio.Condition prevents cancellation

Change by Bar Harel : -- pull_requests: +5467 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue32841] Asyncio.Condition prevents cancellation

Change by Yury Selivanov : Removed file: https://bugs.python.org/file47441/le_meme.jpg ___ Python tracker ___ ___ Python-bugs-list mailing li

[issue32841] Asyncio.Condition prevents cancellation

Yury Selivanov added the comment: le_meme.jpg is a pretty common facial expression when one debugs locks/conditions, so let's not attach it in the future :) We try to keep the bug tracker free of unnecessary information. As for the bug—please submit a PR! -- ___

[issue32841] Asyncio.Condition prevents cancellation

Change by Bar Harel : -- keywords: +patch Added file: https://bugs.python.org/file47440/le_patch.diff ___ Python tracker ___ ___ Pyth

[issue32841] Asyncio.Condition prevents cancellation

New submission from Bar Harel : Hey guys, A week after a serious asyncio.Lock bug, I found another bug that makes asyncio.Condition ignore and prevent cancellation in some cases due to an "except: pass" which tbh is a little embarrassing. What happens is that during the time it takes to get b

[issue32841] Asyncio.Condition prevents cancellation

Change by Bar Harel : Added file: https://bugs.python.org/file47441/le_meme.jpg ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu