[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: Ok, the issue should now be fixed. Thanks Iryna Shcherbina for your bug report, and thanks Marcel Plch for your initial fix! Marcel: my final fix is based on yours, I just made the "next" conditional. -- resolution: -> fixed stage: patch review ->

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset b274f1ce5c62dd517338b8323fb9eb5aaa09c7cd by Victor Stinner in branch '2.7': bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656) (GH-9788)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +9171 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

miss-islington added the comment: New changeset 0ce31d340b264a550a3c574e1d6913f4affd4669 by Miss Islington (bot) in branch '3.7': bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

miss-islington added the comment: New changeset 25bfb1aa75c8358becdab11142954c8ee9c3607f by Miss Islington (bot) in branch '3.6': bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by miss-islington : -- pull_requests: +9159 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by miss-islington : -- pull_requests: +9158 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 79d21331e605fdc941f947621846b8563485aab6 by Victor Stinner in branch 'master': bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-9656)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: I tested the following configurations on my Fedora 28: ./configure --with-pydebug CFLAGS=-O0 -mcet -fcf-protection ./configure CFLAGS=-mcet -fcf-protection ./configure --with-pydebug CFLAGS=-O0 -mcet -fcf-protection=none ./configure CFLAGS=-mcet

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: More info about -fcf-protection=full -mcet: "Enable control flow protection on x86-64 using -fcf-protection=full -mcet." https://fedoraproject.org/wiki/Changes/HardeningFlags28 man gcc: -fcf-protection=[full|branch|return|none] Enable code

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +9048 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: Oh I see. But currently, many test_gdb tests pass even with optimization. I dislike reducing the test coverage when Python is compiled with optimizations, just to support -mcet -fcf-protection. Would it be possible to detect the special case "-mcet

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Marcel Plch added the comment: > It's already done, no? But the title issue is "-mcet -fcf-protection > -O0" and -O0 disables optimizations. Some of the simple tests are still run even with optimizations. Disabled optimizations is what we want, because then the function doesn't get inlined

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: Related issue: bpo-31237. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: > 1) Skip whole test_gdb when optimizations are used (who debugs with them > anyway?) It's already done, no? But the title issue is "-mcet -fcf-protection -O0" and -O0 disables optimizations. -- ___ Python

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Charalampos Stratakis added the comment: I'd say there are use cases where gdb will be used with optimizations especially in downstream distribution. -- ___ Python tracker

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Marcel Plch added the comment: The problem is with this function: static PyObject * builtin_id(PyModuleDef *self, PyObject *v) /*[clinic end generated code: output=0aa640785f697f65 input=5a534136419631f4]*/ { return PyLong_FromVoidPtr(v); } It's a one-liner, so the compiler really likes

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset e36f94f204f3257a206a7766464a94230337fd18 by Victor Stinner in branch '2.7': bpo-32962: Backport python-gdb.py and test_gdb.py from master (GH-7726) https://github.com/python/cpython/commit/e36f94f204f3257a206a7766464a94230337fd18 --

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7339 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset ba67b4f7cb87035e24098f52cf9711b9e793e033 by Victor Stinner in branch '3.7': Revert "bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-6754)" (#7724)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 74565aa6d54344d4994c6b81d6fd05a4258283ab by Victor Stinner in branch '3.6': Revert "bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-6754)" (#7725)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 2f9cbaa8b2190b6dfd3157ede9b6973523a3b939 by Victor Stinner in branch 'master': Revert "bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (GH-6754)" (#7723)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7338 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7337 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: > Oh :-( The change caused two buildbot failures, so I wrote PR 7723 to revert > it. It seems to only be related to this change: """ New changeset 9b7c74ca32d1bec7128d550a9ab1b2ddc7046287 by Victor Stinner (Marcel Plch) in branch 'master': bpo-32962: Fix

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg319670 ___ Python tracker ___ ___ Python-bugs-list

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Pablo Galindo Salgado added the comment: test_gdb is failing on the following buildbots: x86 Gentoo Non-Debug http://buildbot.python.org/all/#builders/99/builds/1095 AMD64 Debian PGO 3.x http://buildbot.python.org/all/#builders/47/builds/1173 Gentoo Non-Debug with X 3.7

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: Oh :-( The change caused two buildbot failures, so I wrote PR 7723 to revert it. x86 Gentoo Non-Debug with X 3.x: http://buildbot.python.org/all/#/builders/99/builds/1095 == FAIL:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7336 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 5279759f52cc5397acfb04351b34feea862864de by Victor Stinner in branch '3.6': bpo-32962: Backport python-gdb.py and test_gdb.py from master (GH-7710) (GH-7711) https://github.com/python/cpython/commit/5279759f52cc5397acfb04351b34feea862864de

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7325 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset ca4cb8492c643d1fcac2c5b749595ad5377673ab by Victor Stinner in branch '3.7': [3.7] bpo-32962: Backport python-gdb.py and test_gdb.py from master (GH-7710) https://github.com/python/cpython/commit/ca4cb8492c643d1fcac2c5b749595ad5377673ab

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7324 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 9b7c74ca32d1bec7128d550a9ab1b2ddc7046287 by Victor Stinner (Marcel Plch) in branch 'master': bpo-32962: Fix test_gdb failure in debug build with -mcet -fcf-protection -O0 (#6754)

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: Reminder: test_gdb is skipped on Travis CI and AppVeyor. I tested my two changes manually. I will backport python-gdb.py enhancements to other branches once PR 6754 fix will be merged. -- ___ Python tracker

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset d22fc0bc7de7882da204abe50884bbde2da4f9e7 by Victor Stinner in branch 'master': bpo-32962: python-gdb catchs UnicodeDecodeError (GH-7693) https://github.com/python/cpython/commit/d22fc0bc7de7882da204abe50884bbde2da4f9e7 --

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: > Wouldn't be better to use the "surrogateescape" or the "backslashreplace" > error handlers? Are you talking about my https://github.com/python/cpython/pull/7693 fix? If yes, the error comes from the string() method which comes from the gdb API. I don't

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Serhiy Storchaka added the comment: Wouldn't be better to use the "surrogateescape" or the "backslashreplace" error handlers? -- nosy: +serhiy.storchaka ___ Python tracker

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

STINNER Victor added the comment: New changeset 019d33b7a447e78057842332fb5d3bad01922122 by Victor Stinner in branch 'master': bpo-32962: python-gdb catchs ValueError on read_var() (GH-7692) https://github.com/python/cpython/commit/019d33b7a447e78057842332fb5d3bad01922122 -- nosy:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7307 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by STINNER Victor : -- pull_requests: +7306 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Charalampos Stratakis added the comment: Ping. Could someone take a look? There is a PR ready. -- ___ Python tracker ___

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by Marcel Plch : -- keywords: +patch pull_requests: +6441 stage: -> patch review ___ Python tracker ___

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

Change by Charalampos Stratakis : -- nosy: +Dormouse759 ___ Python tracker ___ ___

[issue32962] test_gdb fails in debug build with `-mcet -fcf-protection -O0`

New submission from Iryna Shcherbina : test_gdb fails on Fedora 28. This happens only in debug build, and only if built with control flow protection flags: `-mcet -fcf-protection` AND optimization `-O0`. Reproduction steps on Fedora 28 (x86_64): ./configure