[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

miss-islington added the comment: New changeset 545fc51d950558ecec9ff64cb2f9c11469051524 by Miss Islington (bot) in branch '3.8': bpo-32989: IDLE - remove unneeded parameter (GH-18138) https://github.com/python/cpython/commit/545fc51d950558ecec9ff64cb2f9c11469051524 --

[issue32989] IDLE: Fix pyparse.find_good_parse_start

miss-islington added the comment: New changeset 36968c13cb9800559dbb90686933da7daf52c788 by Miss Islington (bot) in branch '3.7': bpo-32989: IDLE - remove unneeded parameter (GH-18138) https://github.com/python/cpython/commit/36968c13cb9800559dbb90686933da7daf52c788 --

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Terry J. Reedy added the comment: New changeset f9e07e116c32b6dc4561d0bdeb452ccde13b0e7c by Terry Jan Reedy in branch 'master': bpo-32989: IDLE - remove unneeded parameter (GH-18138) https://github.com/python/cpython/commit/f9e07e116c32b6dc4561d0bdeb452ccde13b0e7c --

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by miss-islington : -- pull_requests: +17525 pull_request: https://github.com/python/cpython/pull/18139 ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by miss-islington : -- pull_requests: +17526 pull_request: https://github.com/python/cpython/pull/18140 ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by Terry J. Reedy : -- pull_requests: +17524 pull_request: https://github.com/python/cpython/pull/18138 ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Terry J. Reedy added the comment: Tim, idlelib.pyparse has this definition: # Find what looks like the start of a popular statement. _synchre = re.compile(r""" ^ [ \t]* (?: while | else | def | return | assert | break | class | continue

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Terry J. Reedy added the comment: Cheryl, sorry to take so long. I will look at and probably remove the _synchre parameter, on this issue. Feel free to pursue any of the other possible followups. -- versions: +Python 3.9 -Python 3.6 ___ Python

[issue32989] IDLE: Fix pyparse.find_good_parse_start

miss-islington added the comment: New changeset 060ad2fc1535adc76f96be8269b4af0f14429161 by Miss Islington (bot) in branch '3.8': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/060ad2fc1535adc76f96be8269b4af0f14429161 --

[issue32989] IDLE: Fix pyparse.find_good_parse_start

miss-islington added the comment: New changeset f3d3a3cc114ed30829544c3613b73e4fa6dd5599 by Miss Islington (bot) in branch '3.7': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/f3d3a3cc114ed30829544c3613b73e4fa6dd5599 --

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by miss-islington : -- pull_requests: +17487 pull_request: https://github.com/python/cpython/pull/18097 ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Terry J. Reedy added the comment: New changeset ec64640a2c5236d7a5d5470d759172a3d93eab0b by Terry Jan Reedy (Cheryl Sabella) in branch 'master': bpo-32989: IDLE - fix bad editor call of pyparse method (GH-5968) https://github.com/python/cpython/commit/ec64640a2c5236d7a5d5470d759172a3d93eab0b

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Change by miss-islington : -- pull_requests: +17486 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/18096 ___ Python tracker ___

[issue32989] IDLE: Fix pyparse.find_good_parse_start

Terry J. Reedy added the comment: After updating the patch, I noticed that deletion of self.context_use_ps1 from the editor call to y.find_good_parse_start was no longer part of the diff. This is because 3.8 changeset 6bdc4dee01788599808c7858e2fe9fdd72cf6792 for #35610 (backported only to

[issue32989] IDLE: Fix pyparse.find_good_parse_start and its bad editor call

Cheryl Sabella added the comment: > In the meanwhile, to get some idea of how well find_good_parse_start finds > good parse starts, I restarted IDLE in a console with the print still added, > loaded editor.py, and hit RETURN followed by UNDO, in various places. The > first

[issue32989] IDLE: Fix pyparse.find_good_parse_start and its bad editor call

Terry J. Reedy added the comment: I agree with limiting the scope to the None bug and the faulty call. However, we should think of the None fix as primary, and the new test thereof as the primary test. Fixing the None check exposes the call bug, which we also fix. I