Changes by Brett Cannon [EMAIL PROTECTED]:
--
priority: - release blocker
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
___
Python-bugs-list
Brett Cannon [EMAIL PROTECTED] added the comment:
Nick, are you going to be able to get this cleaned up today for the beta
release tomorrow?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
Nick Edds [EMAIL PROTECTED] added the comment:
I should be able to. What time would you need it by?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
___
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Today or tomorrow.
--
nosy: +benjamin.peterson
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
Barry A. Warsaw [EMAIL PROTECTED] added the comment:
I would really like to get this in by beta2, but it's not quite enough
to hold up the release. Please try to get this cleaned up and committed
by July 16 for beta 2.
--
nosy: +barry
priority: release blocker - deferred blocker
Nick Edds [EMAIL PROTECTED] added the comment:
I've got it finished, I just need to write some tests for it. It will
all be done later tonight.
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
Barry A. Warsaw [EMAIL PROTECTED] added the comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On Jul 15, 2008, at 8:10 PM, Nick Edds wrote:
Nick Edds [EMAIL PROTECTED] added the comment:
I've got it finished, I just need to write some tests for it. It will
all be done later tonight.
Nick Edds [EMAIL PROTECTED] added the comment:
Here is a working version with tests. I believe it has all the desired
functionality, but correct me if I'm wrong Brett. Also, I did not model
MAPPING as suggested by Collin because order was important in generating
tests, so I didn't think using a
Collin Winter [EMAIL PROTECTED] added the comment:
- You should add tests to test_fixers to ensure that this does what you
expect. This will make it much easier for others to modify this fixer
later. You can probably just reuse the tests Brett initially added.
- There's a better data structure
Brett Cannon [EMAIL PROTECTED] added the comment:
What Collin said. =)
I will put robotparser and urlparse into fix_imports myself and continue
to update the docs in 2.x for urllib(2).
Thanks to the both of you for helping with this! It's going to be great
once this fixer is ready to go as it
Changes by Senthil [EMAIL PROTECTED]:
--
nosy: +orsenthil
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue3316
___
___
Python-bugs-list mailing list
New submission from Nick Edds [EMAIL PROTECTED]:
Here is my proposed fix_urllib. The transform function is massive
because there are a lot of cases, so maybe I should break it into
separate functions for each case, and it could maybe do with some more
documentation as well. I also use FromImport
Nick Edds [EMAIL PROTECTED] added the comment:
I broke up transform into the logical pieces of it, so I think now the
code is a little bit more clear.
Added file: http://bugs.python.org/file10846/fix_urllib.diff
___
Python tracker [EMAIL PROTECTED]
13 matches
Mail list logo