[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: Tests are maybe not perfect, but the initial issue is fixed: test_asyncio pass again on FreeBSD buildbots. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: With my latest change, all sendfile tests pass in 17 sec on my FreeBSD VM, so I think that it's fine. Let's see if this test now always pass on FreeBSD buildbots. -- ___ Python tracker

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Yury Selivanov added the comment: > It seems like Yury's commit 7165754b6b5f3b7c07050d921fa1c58bba5f0ff1 made > sendfile tests of test_asyncio 6x slower on FreeBSD :-( Well, yeah, I kind of expected to see a performance regression here. Before, we were reading from a file directly, which

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

miss-islington added the comment: New changeset 441afbd9c3ae3a9f1d6c985c8aa13e6205ba080b by Miss Islington (bot) in branch '3.7': bpo-33353: test_asyncio use set_write_buffer_limits() (GH-7200) https://github.com/python/cpython/commit/441afbd9c3ae3a9f1d6c985c8aa13e6205ba080b --

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: "On my PR 7200, test_sendfile_close_peer_in_the_middle_of_receiving() fails on Windows (AppVeyor) (...)" I worked around this bug in my commit 9551f7719213243fd96c4f284079243773c26b3c by using a buffer of 128 KiB instead of 64 KiB. I created the issue

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by miss-islington : -- pull_requests: +6837 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: New changeset 9551f7719213243fd96c4f284079243773c26b3c by Victor Stinner in branch 'master': bpo-33353: test_asyncio use set_write_buffer_limits() (GH-7200) https://github.com/python/cpython/commit/9551f7719213243fd96c4f284079243773c26b3c --

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: On my PR 7200, test_sendfile_close_peer_in_the_middle_of_receiving() fails on Windows (AppVeyor) :-( For the SelectorEventLoop, it seems like sock.setsockopt(socket.SOL_SOCKET, socket.SO_SNDBUF, 1024) doesn't work as intented: sock.send(<16384 bytes>)

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: Timing at my previous commit b97de3dd86046ac46567146d86a69d4f78ea09db: 3 min 40 sec It seems like Yury's commit 7165754b6b5f3b7c07050d921fa1c58bba5f0ff1 made sendfile tests of test_asyncio 6x slower on FreeBSD :-( --

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: Yury Selivanov made recent changes on sendfile(): bpo-32410, commit 7165754b6b5f3b7c07050d921fa1c58bba5f0ff1. I ran the following command on my FreeBSD VM: ./python -m test test_asyncio -m '*sendfile*' -v Results: * master (commit

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by STINNER Victor : -- pull_requests: +6835 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: > http://buildbot.python.org/all/#/builders/112/builds/62 On the previous build, test_asyncio only took 3 min 54 sec: far from the 15 min timeout limit :-( -- ___ Python tracker

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: Similar failure on AMD64 FreeBSD CURRENT Non-Debug 3.7: http://buildbot.python.org/all/#/builders/112/builds/62 Timeout (0:15:00)! Thread 0x000801324000 (most recent call first): File

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Yury Selivanov added the comment: Andrew, I'm out of capacity here, could you please take a look when you have time? -- ___ Python tracker ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: Hum, the test still fails on AMD64 FreeBSD CURRENT Debug 3.x :-( http://buildbot.python.org/all/#/builders/60/builds/77 test_sock_client_ops (test.test_asyncio.test_events.PollEventLoopTests) ... ok Timeout (0:15:00)! Thread 0x00080139d000 (most recent

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: test_asyncio doesn't hang on FreeBSD 3.x buildbot anymore! macOS buildbot is back to green as well. It seems like I can close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: bpo-32708 has been marked as a duplicate of this issue. -- ___ Python tracker ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: New changeset fa24c1c5afa9ba2453d88db5ed6b9d2cc3b58384 by Victor Stinner in branch '3.7': [3.7] bpo-33353: Fix test_asyncio on FreeBSD (GH-7087) https://github.com/python/cpython/commit/fa24c1c5afa9ba2453d88db5ed6b9d2cc3b58384

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by STINNER Victor : -- pull_requests: +6721 ___ Python tracker ___ ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: New changeset b97de3dd86046ac46567146d86a69d4f78ea09db by Victor Stinner in branch 'master': bpo-33353: test_asyncio set SO_SNDBUF after connect (GH-7086) https://github.com/python/cpython/commit/b97de3dd86046ac46567146d86a69d4f78ea09db

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: My change caused a regression on macOS: bpo-33626. I just closed this issue as a duplicate of this one. -- ___ Python tracker

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by STINNER Victor : -- pull_requests: +6719 ___ Python tracker ___ ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by miss-islington : -- pull_requests: +6716 ___ Python tracker ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

STINNER Victor added the comment: New changeset 2932755cc11fd82b4908d60b24b837aa4f3028e6 by Victor Stinner in branch 'master': bpo-33353: test_asyncio uses smaller sendfile data (#7083) https://github.com/python/cpython/commit/2932755cc11fd82b4908d60b24b837aa4f3028e6

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

Change by STINNER Victor : -- keywords: +patch pull_requests: +6714 stage: -> patch review ___ Python tracker ___

[issue33353] test_asyncio: test_sock_sendfile_mix_with_regular_send() hangs on FreeBSD

New submission from STINNER Victor : Example with a timeout of 10 seconds: vstinner@freebsd$ ./python -m test -v test_asyncio -m test_sock_sendfile_mix_with_regular_send -v --timeout=10 == CPython 3.8.0a0 (heads/master:0977091dca, Apr 25 2018, 14:02:04) [Clang 4.0.0