[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by miss-islington : -- pull_requests: +6813 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by miss-islington : -- pull_requests: +6814 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: Already fixed in GH-7169, GH-7176 and GH-7177 (which I apparently typo'd "bpo" in the commit message, so they didn't link up properly here). -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

STINNER Victor added the comment: It seems like the commit c489a767af46f33e73d96a5746e46a7365814db2 broke the AMD64 Windows10 buildbot: bpo-33675. I reopen this issue. -- resolution: fixed -> status: closed -> open ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: I *believe* this change will prevent the issue in the future, so marking this as fixed. But I wasn't able to reproduce it locally, so there may be something funny about either the file system or the version of MSBuild on the buildbots that caused it to not

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

miss-islington added the comment: New changeset 3757939e9c00a36f939d774ec5c79e5d6b9a77bb by Miss Islington (bot) in branch '3.7': bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated. (GH-7165)

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by Steve Dower : -- pull_requests: +6804 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

miss-islington added the comment: New changeset c489a767af46f33e73d96a5746e46a7365814db2 by Miss Islington (bot) in branch '3.6': bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated. (GH-7165)

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: Thanks! I guess we were getting lucky in the past, as that error could have shown up for any number of reasons... -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: Steve - PR 7165 appears to have caused a buildbot failure: http://buildbot.python.org/all/#/builders/12/builds/910 -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by miss-islington : -- pull_requests: +6803 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by miss-islington : -- pull_requests: +6802 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: New changeset e97ba4c690613d734843db218aeedce2f0e5937f by Steve Dower in branch 'master': bpo-33614: Ensures module definition files for the stable ABI on Windows are correctly regenerated. (GH-7165)

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by Steve Dower : -- keywords: +patch pull_requests: +6800 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: Sorry, I *did* close the issue prematurely; thanks for noticing! -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: Considering we didn't change anything in the sources, I wouldn't expect it to be fixed. It doesn't have to block 3.7 if Ned's okay with it, but I'd like to keep this open and fix the build scripts. -- resolution: fixed ->

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Serhiy Storchaka added the comment: I think the underlying issue is not fixed still. Adding new symbols in python3.def will break this buildbot (as well as users worktrees) again. -- ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: That Windows8.1 buildbot sure keeps busy with all those builders assigned to it :) Those refleaks builds take a *long* time! http://buildbot.python.org/all/#/workers/11 But I see at least one builder has made it through successfully and no

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: er, "cleaned out" -- ___ Python tracker ___ ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: Okay, I'll take a look now. -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: Steve: just a minute ago, zware out the win8.1 bot's repo and restarted a 3.7 build. -- ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by Ned Deily : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: > All the critical builds should forcibly rebuild it, so this isn't urgent, but > I'll take a look next time I get a chance to work on the build files. It's more than a *bit* urgent since it is causing one of the 3.7 stable buildbots to fail to

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Ned Deily added the comment: (for example, http://buildbot.python.org/all/#/builders/133/builds/251 ) -- ___ Python tracker ___

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Serhiy Storchaka added the comment: If "PCbuild\build.bat -p x64" builds Python, "PCbuild\clean.bat -p x64" removes all files in PCbuild\amd64 but python3stub.exp and python3stub.lib. -- ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Steve Dower added the comment: I guess that means there is an invalid date comparison going on to detect when the file has changed. This file doesn't change often, so it's easy to miss :) All the critical builds should forcibly rebuild it, so this isn't urgent, but

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Serhiy Storchaka added the comment: It succeeds after removing directories amd64 and obj in PCbuild. Seems they are left from old builds and the clean up script did nor remove them. This may be a cause of other weird bugs on Windows. --

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Serhiy Storchaka added the comment: My bad, I didn't test that change on Windows myself, and CI seems was broken at that moment. But I have no ideas why the build is failed. These names are part of stable ABI since version 3.7. I don't see any difference between

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by STINNER Victor : -- components: +Build, Windows nosy: +paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware ___ Python tracker

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

New submission from STINNER Victor : http://buildbot.python.org/all/#/builders/80/builds/244 (Link target) -> python3_d.def : error LNK2001: unresolved external symbol PyImport_GetModule

[issue33614] Compilation of Python fails on AMD64 Windows8.1 Refleaks 3.x

Change by STINNER Victor : -- versions: +Python 3.8 ___ Python tracker ___ ___