[issue33648] unused with_c_locale_warning option in configure should be removed

miss-islington added the comment: New changeset 020f5ab7170836b277ac8fef2ce7438ae0145caf by Miss Islington (bot) in branch '3.7': bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114) https://github.com/python/cpython/commit/020f5ab7170836b277ac8fef2ce7438ae0145caf -- nosy: +miss-islingto

[issue33648] unused with_c_locale_warning option in configure should be removed

Change by miss-islington : -- pull_requests: +7782 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue33648] unused with_c_locale_warning option in configure should be removed

Change by INADA Naoki : -- versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue33648] unused with_c_locale_warning option in configure should be removed

INADA Naoki added the comment: Hm, it seems safe to backport. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscri

[issue33648] unused with_c_locale_warning option in configure should be removed

STINNER Victor added the comment: Should we backport the change to 3.7? -- versions: +Python 3.8 ___ Python tracker ___ ___ Python-

[issue33648] unused with_c_locale_warning option in configure should be removed

INADA Naoki added the comment: thanks -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ __

[issue33648] unused with_c_locale_warning option in configure should be removed

INADA Naoki added the comment: New changeset b91a3a0d61596cafb1b46c98fab65fee16a8 by INADA Naoki (Eitan Adler) in branch 'master': bpo-33648: Remove PY_WARN_ON_C_LOCALE (GH-7114) https://github.com/python/cpython/commit/b91a3a0d61596cafb1b46c98fab65fee16a8 -- nosy: +inada.na

[issue33648] unused with_c_locale_warning option in configure should be removed

Eitan Adler added the comment: yeah, I was looking at that too. I think someone else modified related files but never ran a regen (or did so with different tooling than I). Even on master, my regen results in changes. -- ___ Python tracker

[issue33648] unused with_c_locale_warning option in configure should be removed

Nick Coghlan added the comment: Huh, I thought I cleaned those out when I made the compilation unconditional. I guess not :) The actual fix looks good to me, but the autoconf regeneration looks unexpectedly noisy, so I've asked Benjamin Peterson to take a look at it. --

[issue33648] unused with_c_locale_warning option in configure should be removed

Change by Eitan Adler : -- keywords: +patch pull_requests: +6752 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33648] unused with_c_locale_warning option in configure should be removed

STINNER Victor added the comment: It's related to the PEP 538. Note: see also the PEP 540 (not directly related). -- nosy: +ncoghlan, vstinner ___ Python tracker ___ _

[issue33648] unused with_c_locale_warning option in configure should be removed

New submission from Eitan Adler : There is an option for --with-c-locale-warning which was turned into a run-time option in eb81795d7d3a8c898fa89a376d63fc3bbfb9a081. The configuration should be cleaned up. -- messages: 317676 nosy: eitan.adler priority: normal severity: normal status: