[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset 68299305c7898eb8eb0cea6cad19c299d0d1ba2d by Miss Islington (bot) in branch '3.6': bpo-33656: Move pyshell ctypes import inside try block. (GH-9858) https://github.com/python/cpython/commit/68299305c7898eb8eb0cea6cad19c299d0d1ba2d --

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset 77e0abe228564a5be23284bd8e963c11952eb55b by Miss Islington (bot) in branch '3.7': bpo-33656: Move pyshell ctypes import inside try block. (GH-9858) https://github.com/python/cpython/commit/77e0abe228564a5be23284bd8e963c11952eb55b --

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +9232 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset d274afb5e579a5d9d990f68f9af856cf4c918779 by Terry Jan Reedy in branch 'master': bpo-33656: Move pyshell ctypes import inside try block. (GH-9858) https://github.com/python/cpython/commit/d274afb5e579a5d9d990f68f9af856cf4c918779 --

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +9231 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: There is still no rush as guarding the ctypes import on Windows builds that can run IDLE may never be needed. But I grepped the stdlib .py code and uuid is the only .py module that imports ctypes, and all are directly or indirectly guarded in the code or

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- pull_requests: +9226 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

Tal Einat added the comment: Ping? Do we want to get this in for 3.7.1 and 3.6.7? -- nosy: +taleinat ___ Python tracker ___ ___

[issue33656] IDLE: Turn on DPI awareness on Windows

Serhiy Storchaka added the comment: I don't know whether this is a theoretical or a real concern, but I think this fix can wait for 3.7.1. -- ___ Python tracker ___

[issue33656] IDLE: Turn on DPI awareness on Windows

Steve Dower added the comment: There's no option to omit ctypes, though I am aware of some custom builds of Python that exclude it. I don't think you need to worry about those being used for IDLE (but of course the general policy of the stdlib not relying on ctypes remains). --

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: I just ran the 3.7.0rc1 installer and here is no option to omit ctypes. -- ___ Python tracker ___

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: I confirmed that IDLE did not import ctypes before this issue. Serhiy, I presume that the new code can be skipped, you are suggesting replacing import ctypes with try: import ctypes except ImportError: pass # The ctypes-using fix is not

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Serhiy Storchaka added the comment: I can't test on multiple monitors, but I tested on a single HiDPI monitor. With 1 it looks much better than with 0. With 2 it looks the same as with 1 on HiDPI, but doesn't scale well after changing the resolution of the display. I suppose there are the

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset 2023eafd9a0554823cab5adf5a1b116d7984db98 by Miss Islington (bot) in branch '3.6': bpo-33656: Mention color in idlelib/NEWS.txt entry. (GH-7646) https://github.com/python/cpython/commit/2023eafd9a0554823cab5adf5a1b116d7984db98 --

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset 6530577e29a9679c7e4c7ba7adf1c02393d2ad13 by Terry Jan Reedy (Miss Islington (bot)) in branch '3.7': bpo-33656: Mention color in idlelib/NEWS.txt entry. (GH-7646) (GH-7647)

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7267 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7266 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset 4b704f29f5a0b6f6d7bd67468ed004bd3a96855d by Terry Jan Reedy in branch 'master': bpo-33656: Mention color in idlelib/NEWS.txt entry. (#7646) https://github.com/python/cpython/commit/4b704f29f5a0b6f6d7bd67468ed004bd3a96855d --

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Since there should be time before .rcs are cut, I changed the idlelib NEWS.txt entry to mention color changes, based on editing with the change in place. -- stage: patch review -> resolved ___ Python tracker

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- pull_requests: +7265 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset afa1ea5bfd18947aa732a1ea09220aefbed81e1c by Miss Islington (bot) in branch '3.6': bpo-33656: Add enum name for argument of Windows call. (GH-7642) https://github.com/python/cpython/commit/afa1ea5bfd18947aa732a1ea09220aefbed81e1c --

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset d26277a73b61277ad9568cff6503d55deef07223 by Miss Islington (bot) in branch '3.7': bpo-33656: Add enum name for argument of Windows call. (GH-7642) https://github.com/python/cpython/commit/d26277a73b61277ad9568cff6503d55deef07223 --

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7263 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7262 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset fd88f319a4f40682b989b63f0b6378d69465fda4 by Terry Jan Reedy in branch 'master': bpo-33656: Add enum name for argument of Windows call. (GH-7642) https://github.com/python/cpython/commit/fd88f319a4f40682b989b63f0b6378d69465fda4 --

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- pull_requests: +7261 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Reopening, temporarily, to add change requested by Eryk Sun after the merge. -- status: closed -> open ___ Python tracker ___

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Thanks everyone for the help. I think this is the right patch, but as with many IDLE patches, it is hard to be sure until it is in use. At least there is no question here of tk Windows-Linux-MacOS differences. I checked that the Win 7 buildbots are OK

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset 0404d35f9dc89748949935a9178d28bedde9d8c8 by Miss Islington (bot) in branch '3.6': bpo-33656: On Windows, add API call saying that tk scales for DPI (GH-7137) https://github.com/python/cpython/commit/0404d35f9dc89748949935a9178d28bedde9d8c8

[issue33656] IDLE: Turn on DPI awareness on Windows

miss-islington added the comment: New changeset 144a8670f24a157642c5f7fbaf518e87c7c1b969 by Miss Islington (bot) in branch '3.7': bpo-33656: On Windows, add API call saying that tk scales for DPI (GH-7137) https://github.com/python/cpython/commit/144a8670f24a157642c5f7fbaf518e87c7c1b969

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7260 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7259 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by miss-islington : -- pull_requests: +7258 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset 8a05f559ce5064df68c8d4ebd7d4ed28381d9971 by Terry Jan Reedy in branch 'master': bpo-33656: Add entry to What's New 3.7. (GH-7638) https://github.com/python/cpython/commit/8a05f559ce5064df68c8d4ebd7d4ed28381d9971 --

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: New changeset 800415e3df69f494afe9f95a8563ce17609fe1da by Terry Jan Reedy in branch 'master': bpo-33656: On Windows, add API call saying that tk scales for DPI (GH-7137) https://github.com/python/cpython/commit/800415e3df69f494afe9f95a8563ce17609fe1da

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- pull_requests: +7257 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33656] IDLE: Turn on DPI awareness on Windows

Steve Dower added the comment: Yep, that should be fine. If you want to add it to the winapi module rather than use ctypes that's fine too. -- ___ Python tracker ___

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Steve, I would like to add the SetProcessDpiAwareness(1) call to IDLE tomorrow, for 3.7.0 and 3.6.6. Do I need to make it an avoidable option? Can it hurt people on some machines? It seems to me that if tk is doing dpi scaling, then it should always be

[issue33656] IDLE: Turn on DPI awareness on Windows

Steve Dower added the comment: I'm okay to add it to the manifest for both in 3.8, along with a What's New entry. High DPI screens are very common though, and adding it to existing releases won't allow existing apps or frameworks to account for the change. I don't want non-DPI aware apps

[issue33656] IDLE: Turn on DPI awareness on Windows

Eric Fahlgren added the comment: So maybe add the dpiAware and dpiAwareness settings to the manifest for just Windows' pythonw.exe and leave the python.exe console interpreter alone? I'm going to guess that the pythonw.exe manifest already has some settings related to its unique status

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Eric, thanks for the additional reference. From Window's viewpoint, Python, not IDLE, is the application. IDLE is just input data. I should not touch Python's manifest, and changing it would have to consider other possible gui module input data. This

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: As reported on #26698, which was originally opened as an IDLE issue, but which I turned into a tkinter issue, one can also sharpen text buy opening python(w).exe properties, Compatibility tab, clicking [Change high DPI settings], and then checking []

[issue33656] IDLE: Turn on DPI awareness on Windows

Eric Fahlgren added the comment: https://msdn.microsoft.com/en-us/library/windows/desktop/mt748620(v=vs.85).aspx gives the syntax for adding dpiAwareness to the Windows manifest. -- nosy: +eric.fahlgren ___ Python tracker

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Elisha wrote and I quoted: '[the call] sets DPI awareness'. After reading https://msdn.microsoft.com/en-us/library/windows/desktop/dn280512(v=vs.85).aspx PROCESS_DPI_AWARENESS, what the call sets is the system's idea of what DPI awareness the app/process

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Eryk Sun commented on the PR. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: Thanks for the comments: Ronald: I agree that an int should be passed. I understand your ctype comment as saying that an attribute error before making the call should be the only possible exception. I should have explained the 'unrelated change' to the

[issue33656] IDLE: Turn on DPI awareness on Windows

Serhiy Storchaka added the comment: Perhaps the argument should be 2 for supporting multi-display configuration. Currently I can't do this, but will test this recipe with Hi-DPI monitor and multiple displays after 1-2 weeks. -- ___ Python tracker

[issue33656] IDLE: Turn on DPI awareness on Windows

Zachary Ware added the comment: Does Tcl/Tk have a function for this, and/or should we expose this as a function in Tkinter? Do other platforms (macOS, X/Wayland) have similar functions? -- nosy: +serhiy.storchaka ___ Python tracker

[issue33656] IDLE: Turn on DPI awareness on Windows

Ronald Oussoren added the comment: I'm not a Windows expert, but looking that the API description [1] the patch is not entirely correct. The API takes an integer with 3 valid values, the patch effectively passes the value 1 (which means the application claims to be DPI aware, but won't

[issue33656] IDLE: Turn on DPI awareness on Windows

Terry J. Reedy added the comment: I changed the bare except: to 'except AttributeError:'. If ctypes.windll.shcore.SetProcessDpiAwareness exists, can calling it with True ever fail? -- ___ Python tracker

[issue33656] IDLE: Turn on DPI awareness on Windows

Change by Terry J. Reedy : -- keywords: +patch pull_requests: +6771 ___ Python tracker ___

[issue33656] IDLE: Turn on DPI awareness on Windows

New submission from Terry J. Reedy : On IDLE-dev today, Elisha Paine, from Ranelagh School in England, wrote: ''' I love IDLE (so simple and lightweight compared with other IDEs) and was just wondering if you could add the following code into pyshell.py (as I have done on