[issue33871] Possible integer overflow in iov_setup()

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue33871] Possible integer overflow in iov_setup()

Serhiy Storchaka added the comment: New changeset ada5d99306dc8af21c32cefb3d86891e8553dbc6 by Serhiy Storchaka in branch '3.6': [3.6] bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931) (GH-8584)

[issue33871] Possible integer overflow in iov_setup()

miss-islington added the comment: New changeset 3e4b68875917a4605b45918f9e3232730fed9399 by Miss Islington (bot) in branch '3.7': bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931) https://github.com/python/cpython/commit/3e4b68875917a4605b45918f9e3232730fed9399

[issue33871] Possible integer overflow in iov_setup()

Change by Serhiy Storchaka : -- pull_requests: +8093 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33871] Possible integer overflow in iov_setup()

Change by miss-islington : -- pull_requests: +8092 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33871] Possible integer overflow in iov_setup()

Serhiy Storchaka added the comment: New changeset 9d5727326af53ddd91016d98e16ae7cf829caa95 by Serhiy Storchaka in branch 'master': bpo-33871: Fix os.sendfile(), os.writev(), os.readv(), etc. (GH-7931) https://github.com/python/cpython/commit/9d5727326af53ddd91016d98e16ae7cf829caa95

[issue33871] Possible integer overflow in iov_setup()

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +7538 stage: -> patch review ___ Python tracker ___ ___

[issue33871] Possible integer overflow in iov_setup()

Serhiy Storchaka added the comment: Thank you Pablo and Ned! Seems there is other bug on Mac OS, not related to integer overflow. I am working on it. -- priority: normal -> high ___ Python tracker

[issue33871] Possible integer overflow in iov_setup()

Ned Deily added the comment: Test case: import os fo = open('/tmp/temp', 'wb') fi = open('/tmp/temp', 'rb') os.sendfile(fo.fileno(), fi.fileno(), 0, 0, headers=[b'x' * 2**16] * 2**15) -- run against current master HEAD (2f9cbaa8b2190b6dfd3157ede9b6973523a3b939, as of 2018-06-15)

[issue33871] Possible integer overflow in iov_setup()

Pablo Galindo Salgado added the comment: Docs for sendfile in macOS: https://www.unix.com/man-page/osx/2/sendfile/ -- ___ Python tracker ___

[issue33871] Possible integer overflow in iov_setup()

Pablo Galindo Salgado added the comment: I can reproduce the issue on a i686 GNU/Linux Debian system: >>> import os >>> f = open('/tmp/temp', 'wb') >>> l = os.writev(f.fileno(), [b'x' * 2**16] * 2**15) Traceback (most recent call last): File "", line 1, in SystemError: error return

[issue33871] Possible integer overflow in iov_setup()

New submission from Serhiy Storchaka : The iov_setup() helper in posixmodule.c returns the total size of all buffers. But there is possible an integer overflow because the sequence of buffers can contain the same buffer repeated multiple times. On 32-bit platform: >>> import os >>> f =