[issue33881] dataclasses should use NFKC to find duplicate members

Eric V. Smith added the comment: I agree with Raymond. There's no real harm being caused here. -- resolution: -> wont fix stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33881] dataclasses should use NFKC to find duplicate members

Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) added the comment: I am convinced by Raymond’s argument. Hence closing the PR. -- ___ Python tracker ___

[issue33881] dataclasses should use NFKC to find duplicate members

Raymond Hettinger added the comment: I recommend leaving the code as-is. AFAICT, the situation almost never arises in practice, and if it did, the existing SyntaxError is clear. Given that the rest of that language uses a SyntaxError, there isn't a net benefit for switching to TypeError:

[issue33881] dataclasses should use NFKC to find duplicate members

Change by Srinivas Reddy Thatiparthy(శ్రీనివాస్ రెడ్డి తాటిపర్తి) : -- nosy: +thatiparthy nosy_count: 4.0 -> 5.0 pull_requests: +20031 pull_request: https://github.com/python/cpython/pull/20837 ___ Python tracker

[issue33881] dataclasses should use NFKC to find duplicate members

Cheryl Sabella added the comment: The pull request that was opened for this has been closed due to inactivity, so this issue is available for anyone to work on. -- nosy: +cheryl.sabella versions: +Python 3.10, Python 3.8, Python 3.9 -Python 3.7

[issue33881] dataclasses should use NFKC to find duplicate members

Steve Dower added the comment: > outside of the basic Latin characters (0-255) This should be (0-127). The Latin characters in 128-255 are considered extended ones, and may be decomposed by normalization. -- ___ Python tracker

[issue33881] dataclasses should use NFKC to find duplicate members

Steve Dower added the comment: The benchmark may not be triggering that much work. NFKC normalization only applies for characters outside of the basic Latin characters (0-255). I ran the below benchmarks and saw a huge difference. Granted, it's a very degenerate case with collections this

[issue33881] dataclasses should use NFKC to find duplicate members

Valeriya Sinevich added the comment: I sent a PR and measured how it affected the performance by creating a dataclass with 1 members. python.bat -m timeit -s "from dataclasses import make_dataclass" -s "arg_list = [chr(k) * i for k in range(97, 123) for i in range(1, 500)]"

[issue33881] dataclasses should use NFKC to find duplicate members

Change by Valeriya Sinevich : -- keywords: +patch pull_requests: +7519 stage: -> patch review ___ Python tracker ___ ___

[issue33881] dataclasses should use NFKC to find duplicate members

Change by Eric V. Smith : -- title: dataclasses should use NFKD to find duplicate members -> dataclasses should use NFKC to find duplicate members ___ Python tracker ___