[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Luke Granger-Brown added the comment: Still seems to be a problem with everything up to Py3.11. -- nosy: +lukegb versions: +Python 3.10, Python 3.11, Python 3.8, Python 3.9 ___ Python tracker

[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Daiderd Jordan added the comment: Either patch looks fine to me, should I close the pull request? -- ___ Python tracker ___ ___

[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Ronald Oussoren added the comment: I agree with Ned that we shouldn't add code to deal with non-standard compiler setups, correctly supporting macOS is hard enough as it is. That said, the attached patch (but not PR8056) looks fine to me, it includes all possibly relevant headers files (as

[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Daiderd Jordan added the comment: Even tho it's headers are not /usr/lib/libutil.dylib is available on every macOS system. Unlike on bsd this doesn't include the relevant symbols for openpty/forkpty, that's why I used an __APPLE__ condition but including both also works fine. Assuming it's

[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Orivej Desh added the comment: I understand the desirability of avoiding potential problems on supported platforms (given that you can not test building Python on all of them) and recognize that both options you have given are reasonable, but as I see it posixmodule.c incorrectly uses

[issue34027] python 3.7 openpty/forkpty build failure using nix package manager macOS environment

Ned Deily added the comment: Thanks for the suggested patch but I am not persuaded that there is a problem needing fixing on the Python side. As I see it, Python's posixmodule builds fine in the environments we claim to support, including macOS, and has for a long time. It appears that