[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Tal Einat added the comment: Thanks for the PR, stoksc! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Tal Einat added the comment: New changeset 6f036bb67d5a20c86c29ea5aeace563e3751baab by Tal Einat in branch '2.7': [2.7] bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091) (#8225) https://github.com/python/cpython/commit/6f036bb67d5a20c86c29ea5aeace563e3751baab --

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

miss-islington added the comment: New changeset cb14eb7eedf36cd21aaf41c4d3eb1e6521fa7b11 by Miss Islington (bot) in branch '3.6': bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091) https://github.com/python/cpython/commit/cb14eb7eedf36cd21aaf41c4d3eb1e6521fa7b11 --

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

miss-islington added the comment: New changeset 125371d2c617d886e1a15b8f940ce29124cdc79c by Miss Islington (bot) in branch '3.7': bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091) https://github.com/python/cpython/commit/125371d2c617d886e1a15b8f940ce29124cdc79c --

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by Tal Einat : -- pull_requests: +7763 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by miss-islington : -- pull_requests: +7762 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by miss-islington : -- pull_requests: +7761 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Tal Einat added the comment: New changeset 6b490b5db40fc29588e8e6cc23bb89c4fed74ad5 by Tal Einat (Bradley Laney) in branch 'master': bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091) https://github.com/python/cpython/commit/6b490b5db40fc29588e8e6cc23bb89c4fed74ad5

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by Roundup Robot : -- keywords: +patch pull_requests: +7692 stage: -> patch review ___ Python tracker ___ ___

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by Pablo Galindo Salgado : -- versions: -Python 3.4, Python 3.5 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Karthikeyan Singaravelan added the comment: This might be slightly unrelated but I grepped for similar cases and came across self.fail, "Broken file" in Lib/test/test_file.py at https://github.com/python/cpython/blob/a390cb6b6fb6638e91d699513167e8f35b47f846/Lib/test/test_file.py#L245. I

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Bradley Laney added the comment: Hey again @pablogsal. Thanks for reviewing the email issue again. I'll try to fix and submit a PR for this if that's ok. -- nosy: +Bradley Laney ___ Python tracker

[issue34031] [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet

Change by Pablo Galindo Salgado : -- keywords: +easy title: Incorrect usage of unittest.TestCase in test_urllib2_localnet -> [EASY] Incorrect usage of unittest.TestCase in test_urllib2_localnet ___ Python tracker