[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

david awad added the comment: It's been a while since then but I really think we can get this fix merged in the next two weeks or so. Can someone give this another look? I had a quick question for Serhiy Here: https://github.com/python/cpython/pull/8319#discussion_r273539593 If we could

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Change by Steve Dower : -- keywords: -easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.pyth

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Ammar Askar added the comment: Hey David, thanks for your contribution, I've added some feedback in context of the code on Github. -- ___ Python tracker ___ _

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

david awad added the comment: Hey, I saw the issue and spent some time piecing together a PR for it. I've never contributed to Python before but this seemed like a good place to start! I posted these questions on the PR but I'll echo them here as well. - Should we only handle the specific

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Change by david awad : -- keywords: +patch pull_requests: +7854 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Ammar Askar added the comment: Hey Lysandros. Take a look at https://github.com/python/cpython/blob/master/Lib/wave.py#L126-L139 Notice how there's a Chunk made from the `file` argument but then another Chunk created using the previous chunk as a file. While it might seem like self.size_re

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Lysandros Nikolaou added the comment: Upon checking to see where the RuntimeError is coming from, I noticed that there is some notorious behaviour in chunk.py. If one runs python with the exact same parameters as Jussi Judin did in their first case and after stepping through the call stack u

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

STINNER Victor added the comment: If someone writes a PR, I can review it ;-) -- ___ Python tracker ___ ___ Python-bugs-list mailin

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

Lysandros Nikolaou added the comment: Will you make a PR or shall I try to fix this? -- nosy: +lys.nikolaou ___ Python tracker ___

[issue34088] [EASY] sndhdr.what() throws exceptions on unknown files

STINNER Victor added the comment: I agree that sndhdr.what() should return None and not raise an exception if the file format is not supported or the file is invalid. -- keywords: +easy nosy: +vstinner title: sndhdr.what() throws exceptions on unknown files -> [EASY] sndhdr.what() th