[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by Pablo Galindo Salgado : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-l

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: New changeset eb6ab73f93c8b883a8d75a83560e2b4c59170d95 by Pablo Galindo in branch '3.6': [3.6] bpo-34246: Use no mutable default args in smtplib (GH-8554) (#9112) https://github.com/python/cpython/commit/eb6ab73f93c8b883a8d75a83560e2b4c59170d95 -

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: New changeset 5b7a2cb5caeb7df68e637f45a98632cbc84a51bf by Pablo Galindo in branch 'master': bpo-34246: Make sure test_smtplib always cleans resources when finished (GH-9108) https://github.com/python/cpython/commit/5b7a2cb5caeb7df68e637f45a98632cbc84a

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by Pablo Galindo Salgado : -- pull_requests: +8566 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

miss-islington added the comment: New changeset 9835696ec4c57a9a30f1c11cfb4c5d3e121bf97c by Miss Islington (bot) in branch '3.7': bpo-34246: Use no mutable default args in smtplib (GH-8554) https://github.com/python/cpython/commit/9835696ec4c57a9a30f1c11cfb4c5d3e121bf97c -- nosy: +m

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: New changeset d5fbe9b1a3d65ceeb9159c5ba999ee966a945f76 by Pablo Galindo (Pablo Aguiar) in branch 'master': bpo-34246: Use no mutable default args in smtplib (GH-8554) https://github.com/python/cpython/commit/d5fbe9b1a3d65ceeb9159c5ba999ee966a945f76 -

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by miss-islington : -- pull_requests: +8565 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://ma

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by Pablo Galindo Salgado : -- pull_requests: +8562 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by STINNER Victor : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.py

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Serhiy Storchaka added the comment: See also issue32657. -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mai

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by Serhiy Storchaka : -- components: +email nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Change by Pablo Santiago Blum de Aguiar : -- keywords: +patch pull_requests: +8070 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo S Blum de Aguiar added the comment: This is just to note that I'm investigating this issue as part of the CPython sprint in EuroPython. -- nosy: +scorphus ___ Python tracker __

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

R. David Murray added the comment: That's due to another bug, which will get fixed by #32814, unless you'd like to generate a PR with the this fix in it (fixing the mutable default for smtp_options). -- ___ Python tracker

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: Oh, sorry, my bad. That was precisely what commit 48ed88a93bb0bbeaae9a4cfaa533e4edf13bcb51 changed. The problem with running with -R still happens: == ERROR: test_name_field_not_inclu

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: That was from commit 48ed88a93bb0bbeaae9a4cfaa533e4edf13bcb51 -- ___ Python tracker ___ __

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

R. David Murray added the comment: That's not the code I thought I merged. I'll have to take a look at what actually got merged. -- ___ Python tracker ___ __

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: The TypeError is because the test is misusing the assertRaises API: self.assertRaises(smtplib.SMTPNotSupportedError, smtp.send_message(msg)) should be self.assertRaises(smtplib.SMTPNotSupportedError,

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: I think it may be something extra as test_send_message_error_on_non_ascii_addrs_if_no_smtputf8 is failing when you run the test with -R: ./python -W error -m test test_smtplib -R 3:3 Warning -- threading._dangling was modified by test_smtplib Befo

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

R. David Murray added the comment: Ah, sorry. we just modernized test_smtplib's __main__ section, and I think we lost the thread cleanup code that used to be run around the test suite. We need to add the thread cleanup decorators. -- nosy: +r.david.murray stage: -> needs patch typ

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

Pablo Galindo Salgado added the comment: New failure on AMD64 Windows8.1 Refleaks 3.6: https://buildbot.python.org/all/#builders/64/builds/301 -- ___ Python tracker ___ _

[issue34246] Gentoo Refleaks 3.7: test_smtplib has dangling threads

New submission from Pablo Galindo Salgado : The Gentoo Refleaks 3.7 buildbot is reporting that test_smtplib may be leaving with dangling threads: https://buildbot.python.org/all/#builders/114/builds/179 FAILED (errors=7) Warning -- threading._dangling was modified by test_smtplib Before: <_