[issue34369] kqueue.control() documentation and implementation mismatch

Change by Tal Einat : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Pyt

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: New changeset 46c2eff5adca7dc309f077ec65faf95b95c47b43 by Tal Einat (Miss Islington (bot)) in branch '2.7': bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only (GH-9499) https://github.com/python/cpython/commit/46c2eff5adca7dc309f

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: New changeset d3747fd8fa91b768b73b60f2e2a14044e5404afa by Tal Einat (Miss Islington (bot)) in branch '3.7': bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only (GH-9499) https://github.com/python/cpython/commit/d3747fd8fa91b768b73

[issue34369] kqueue.control() documentation and implementation mismatch

miss-islington added the comment: New changeset dc0b6af42eca70e520b67d0bcf4dc5278a3f02dd by Miss Islington (bot) in branch '3.8': bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only (GH-9499) https://github.com/python/cpython/commit/dc0b6af42eca70e520b67d0bcf

[issue34369] kqueue.control() documentation and implementation mismatch

Change by miss-islington : -- pull_requests: +14506 pull_request: https://github.com/python/cpython/pull/14706 ___ Python tracker ___ __

[issue34369] kqueue.control() documentation and implementation mismatch

Change by miss-islington : -- pull_requests: +14505 pull_request: https://github.com/python/cpython/pull/14705 ___ Python tracker ___ __

[issue34369] kqueue.control() documentation and implementation mismatch

Change by miss-islington : -- pull_requests: +14504 pull_request: https://github.com/python/cpython/pull/14704 ___ Python tracker ___ __

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: New changeset 79042ac4348ccc09344014f20dd49401579f8795 by Tal Einat in branch 'master': bpo-34369: make kqueue.control() docs better reflect that timeout is positional-only (GH-9499) https://github.com/python/cpython/commit/79042ac4348ccc09344014f20dd49401579f879

[issue34369] kqueue.control() documentation and implementation mismatch

Change by Tal Einat : -- versions: +Python 3.8, Python 3.9 -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsu

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: I agree Martin, I hadn't noticed that the docs don't otherwise mention the default behavior WRT timeout. I've added a description as per your suggestion to the PR. -- ___ Python tracker

[issue34369] kqueue.control() documentation and implementation mismatch

Martin Panter added the comment: I think removing all mention of “None” is a step too far. The “devpoll”, “epoll”, and “poll” documentation all say that “None” is acceptable for the timeout. Only the “select” function doesn’t say this. What about adding to the text: * “timeout” in seconds (f

[issue34369] kqueue.control() documentation and implementation mismatch

Change by Tal Einat : -- keywords: +patch pull_requests: +8906 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list m

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: We can just remove the "=None" in the docs for select.kqueue.control() to conform with the rest of that doc. We don't use the PEP 457 slash notation in the docs for select (or perhaps at all?). -- ___ Python tracker

[issue34369] kqueue.control() documentation and implementation mismatch

Martin Panter added the comment: Even in 3.8, the main documentation is not fixed: https://docs.python.org/dev/library/select.html#kqueue-objects -- ___ Python tracker ___ __

[issue34369] kqueue.control() documentation and implementation mismatch

Tal Einat added the comment: In Python 3.8 this will have already been fixed (thanks to the recent conversion of the select module to use Argument Clinic); see below output from a recent build from the master branch. Given that, is this worth fixing on 2.7 and <3.8? Help on built-in functi

[issue34369] kqueue.control() documentation and implementation mismatch

Martin Panter added the comment: I think this was an attempt to specify a positional-only parameter (by using square brackets), and include a default value in the signature. The usual approach in this situation is to use square brackets, but only mention the default value in the text: contr

[issue34369] kqueue.control() documentation and implementation mismatch

Toshio Kuratomi added the comment: I don't believe (kqueue.control at least) is a regression from Argument Clinic. Both the documentation and the behaviour are the same in Python-2.7. -- ___ Python tracker ___

[issue34369] kqueue.control() documentation and implementation mismatch

Berker Peksag added the comment: This is probably a regression from the Argument Clinic conversion. Another docstring mismatches: select(rlist, wlist, xlist, timeout=None, /) Wait until one or more file descriptors are ready for some kind of I/O. >>> select.select(timeout=0.1) Traceback

[issue34369] kqueue.control() documentation and implementation mismatch

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https:/

[issue34369] kqueue.control() documentation and implementation mismatch

New submission from Toshio Kuratomi : The current kqueue documentation specifies that timeout is a keyword argument but it can only be passed as a positional argument right now: >>> import select >>> ko = select.kqueue() >>> ko.control([1], 0, timeout=10) Traceback (most recent call last): F