[issue34384] os.readlink does not accept pathlib.Path on Windows

Steve Dower added the comment: Yep -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34384] os.readlink does not accept pathlib.Path on Windows

Gregory P. Smith added the comment: can this be closed? -- nosy: +gregory.p.smith status: pending -> open ___ Python tracker ___

[issue34384] os.readlink does not accept pathlib.Path on Windows

Change by Serhiy Storchaka : -- status: open -> pending ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34384] os.readlink does not accept pathlib.Path on Windows

Berker Peksag added the comment: New changeset e0b5b2096ead4cc094a129ce7602ac5c0e998086 by Berker Peksag in branch 'master': bpo-34384: Fix os.readlink() on Windows (GH-8740) https://github.com/python/cpython/commit/e0b5b2096ead4cc094a129ce7602ac5c0e998086 --

[issue34384] os.readlink does not accept pathlib.Path on Windows

Berker Peksag added the comment: Thanks for the suggestions! I've updated PR 8740. I will submit separate PRs to fix os.readlink() documentation in 3.6 and 3.7 branches. -- ___ Python tracker

[issue34384] os.readlink does not accept pathlib.Path on Windows

Steve Dower added the comment: Serhiy is exactly right, but to emphasise, the best way to do paths now is to use argument clinic with its path_t type. On Windows, .narrow is a flag that indicates whether you should PyUnicode_FSEncode() any results before returning them, and .wide is always

[issue34384] os.readlink does not accept pathlib.Path on Windows

Serhiy Storchaka added the comment: Currently the behavior doesn't match the documentation. Initially I thought that this can be solved by adding the support of path-like objects and backporting this up to 3.6. But os.readlink() on Windows doesn't not support also bytes paths, and never

[issue34384] os.readlink does not accept pathlib.Path on Windows

Berker Peksag added the comment: In msg235615 (Issue 9949), Zachary said using bytes paths on Windows is deprecated, but I can't see the actual conversation because Rietveld seems to be down: https://bugs.python.org/review/9949/#ps5077 I think the os.readlink() documentation needs to be

[issue34384] os.readlink does not accept pathlib.Path on Windows

Berker Peksag added the comment: Steve and/or Eryk, I was adding some tests for os.readlink() in PR 8740 and I noticed that os.readlink() always returns str on Windows. However, the documentation for os.readlink() says: If the path is a bytes object (direct or indirectly), the result

[issue34384] os.readlink does not accept pathlib.Path on Windows

Change by Serhiy Storchaka : -- components: +Windows nosy: +berker.peksag, paul.moore, serhiy.storchaka, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue34384] os.readlink does not accept pathlib.Path on Windows

Change by Serhiy Storchaka : -- versions: +Python 3.6, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34384] os.readlink does not accept pathlib.Path on Windows

Change by Berker Peksag : -- keywords: +patch pull_requests: +8225 stage: -> patch review ___ Python tracker ___ ___

[issue34384] os.readlink does not accept pathlib.Path on Windows

New submission from Girts Folkmanis : Documentation for os.readlink says "Changed in version 3.6: Accepts a path-like object.". This works fine on macOS, but blows up on Windows: Python 3.7.0 (v3.7.0:1bf9cc5093, Jun 27 2018, 04:06:47) [MSC v.1914 32 bit (Intel)] on win32 Type "help",