[issue34691] _contextvars missing in x64 master branch Windows build?

2018-09-17 Thread Tim Peters
Tim Peters added the comment: FYI, I bet I didn't see a problem with the Win32 target because I followed instructions ;-) and did my first build using build.bat. Using that for the x64 too target makes the problem go away. -- ___ Python tracker

[issue34691] _contextvars missing in x64 master branch Windows build?

2018-09-17 Thread Steve Dower
Steve Dower added the comment: Shouldn't need VS for this change (updating the SLN file generally does need it). I'm happy to do it though. In case someone else gets to it before me: * delete _contextvars.vcxproj and remove all references from PCbuild and Tools/msi * add _contextvars

[issue34691] _contextvars missing in x64 master branch Windows build?

2018-09-17 Thread Yury Selivanov
Yury Selivanov added the comment: > How much do you think it hurts to have it always loaded into memory, even if > it hasn't truly been imported or used? I'd be fine with that. Would you be able to do the necessary change (I don't have VS at hand)? --

[issue34691] _contextvars missing in x64 master branch Windows build?

2018-09-17 Thread Steve Dower
Steve Dower added the comment: It looks like _contextvars has both its own project and is also built as part of pythoncore.vcxproj. However, _contextvars.vcxproj is not in PCbuild.sln, which means when you build through Visual Studio (rather than with build.bat via pcbuild.proj), you don't

[issue34691] _contextvars missing in x64 master branch Windows build?

2018-09-14 Thread Tim Peters
New submission from Tim Peters : Using Visual Studio 2017 to build the current master branch of Python (something I'm trying for the first time in about two years - maybe I'm missing something obvious!), with the x64 target, under both the Release and Debug builds I get a Python that can't